Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support manager config environment variable expansion #1946

Merged
merged 4 commits into from
Nov 8, 2024

Conversation

mrsillydog
Copy link
Contributor

Proposed Change

  • Move from using standard os and yaml methods for reading and unmarshalling manager configuration files to the opentelemetry confmap library
  • Add the envprovider factory to allow for environment variable usage within the manager configuration files.
  • Minor cleanup of unused variables and attributes within the modified test file
Checklist
  • Changes are tested
  • CI has passed

@mrsillydog mrsillydog marked this pull request as ready for review November 7, 2024 18:47
@mrsillydog mrsillydog requested review from dpaasman00 and a team as code owners November 7, 2024 18:47
@jsirianni jsirianni self-requested a review November 7, 2024 19:08
Copy link
Member

@jsirianni jsirianni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great. One question in tests.

opamp/config_test.go Outdated Show resolved Hide resolved
Copy link
Member

@jsirianni jsirianni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great assuming CI passes 👍

@mrsillydog mrsillydog merged commit 9ac8eff into release/v1.64.0 Nov 8, 2024
15 checks passed
@mrsillydog mrsillydog deleted the feat/BPOP-1160 branch November 8, 2024 18:50
dpaasman00 added a commit that referenced this pull request Nov 12, 2024
* chore: Update modules to v1.64.0

* chore: Add OTEL_AES_CREDENTIAL_PROVIDER key to agent description (#1938)

* Add OTEL_AES_CREDENTIAL_PROVIDER key hash to agent description

* Switch to sending key instead of hash, send in NonIdentifyingAttributes

* chore: Deprecate Marshal processor (#1945)

* delete processor and references

* remove from go.mod

* deps: Update OTel v0.113.0 (#1948)

Update OTel v0.113.0

* feat: Support manager config environment variable expansion (#1946)

* feat: Support manager config environment variable expansion

* Minor pointer cleanup

* Uncomment out unused test code

* fix: TestToTLS to use unreferenced config attributes (#1952)

* Fix test to use unreferenced config attributes

* Adjust caCertPool solution

* feat(chronicleexporter): Support dynamic namespace and ingestion labels  (#1939)

* add namespace and ingenstion logs initial commit

* working except ingestion labels

* ingestion labels from attributes

* use proper log entry batch

* namespace and ingestion logs no config overwrite

* delete OverrideNamespace and OverrideIngestionLabeles

* PR changes

* fix unit tests

* modify tests again

* marshal changes

* readme and namespace check

* deps: Bump min Go version to 1.22.7 (#1963)

bump min go version to 1.22.7, remove toolchains

* deps: Dependabot 11-12-2024 (#1962)

* bump snowflake v1.12.0

* bump jwt

* bump google.golang.org/api

* bump google.golang.org/grpc

* bump golang.org/x/oauth2

* bump github.com/mgechev/revive

* bump golang.org/x/tools

* bump golang.org/x/sys

* skip grpc update

* bump grpc

---------

Co-authored-by: Sam Hazlehurst <[email protected]>
Co-authored-by: Daniel Kuiper <[email protected]>
Co-authored-by: Ian Adams <[email protected]>
Co-authored-by: Justin Voss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants