-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support manager config environment variable expansion #1946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsirianni
requested changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working great. One question in tests.
jsirianni
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great assuming CI passes 👍
dpaasman00
added a commit
that referenced
this pull request
Nov 12, 2024
* chore: Update modules to v1.64.0 * chore: Add OTEL_AES_CREDENTIAL_PROVIDER key to agent description (#1938) * Add OTEL_AES_CREDENTIAL_PROVIDER key hash to agent description * Switch to sending key instead of hash, send in NonIdentifyingAttributes * chore: Deprecate Marshal processor (#1945) * delete processor and references * remove from go.mod * deps: Update OTel v0.113.0 (#1948) Update OTel v0.113.0 * feat: Support manager config environment variable expansion (#1946) * feat: Support manager config environment variable expansion * Minor pointer cleanup * Uncomment out unused test code * fix: TestToTLS to use unreferenced config attributes (#1952) * Fix test to use unreferenced config attributes * Adjust caCertPool solution * feat(chronicleexporter): Support dynamic namespace and ingestion labels (#1939) * add namespace and ingenstion logs initial commit * working except ingestion labels * ingestion labels from attributes * use proper log entry batch * namespace and ingestion logs no config overwrite * delete OverrideNamespace and OverrideIngestionLabeles * PR changes * fix unit tests * modify tests again * marshal changes * readme and namespace check * deps: Bump min Go version to 1.22.7 (#1963) bump min go version to 1.22.7, remove toolchains * deps: Dependabot 11-12-2024 (#1962) * bump snowflake v1.12.0 * bump jwt * bump google.golang.org/api * bump google.golang.org/grpc * bump golang.org/x/oauth2 * bump github.com/mgechev/revive * bump golang.org/x/tools * bump golang.org/x/sys * skip grpc update * bump grpc --------- Co-authored-by: Sam Hazlehurst <[email protected]> Co-authored-by: Daniel Kuiper <[email protected]> Co-authored-by: Ian Adams <[email protected]> Co-authored-by: Justin Voss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Change
Checklist