deps: Upgrade opamp v0.17.0 #1906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BinaryFissionGames
force-pushed
the
deps/upgrade-opamp-v0.17.0
branch
from
30cd85f to
0a7ae1a
Compare
BinaryFissionGames
changed the base branch from
release/v1.62.0
to
release/v1.63.0
BinaryFissionGames
requested review from
dpaasman00 and
a team
as code owners
dpaasman00
approved these changes
Oct 23, 2024
BinaryFissionGames
force-pushed
the
deps/upgrade-opamp-v0.17.0
branch
from
0a7ae1a to
c63063e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Change
THIS CHANGE IS INCOMPATIBLE WITH BPOP v1.59.1 AND BELOW
The change from the string ID to byte ID was done in v0.15.0 of opamp-go, and it this makes the v0.15.0 client incompatible with v0.14.0 server.
v1.60.0 was the first BindPlane OP version using v0.15.0 of opamp-go.
This skips adding the heartbeat capability until we can start with it off, see open-telemetry/opamp-go#303
Checklist