fix: add ottl metric condition to expr package for use in sampling processor #1878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic condition in sampling processor
colelaven
requested review from
dpaasman00,
BinaryFissionGames and
a team
as code owners
2 tasks
BinaryFissionGames
suggested changes
Sep 24, 2024
BinaryFissionGames
approved these changes
Sep 24, 2024
BinaryFissionGames
suggested changes
Sep 25, 2024
Comment on lines
39
to
41
| if cfg.Condition == "" { | ||
| cfg.Condition = "true" | ||
| } |
There was a problem hiding this comment.
Do we ever hit this case? We already set the default to this in createDefaultConfig. IMO we shouldn't modify the config in a "Validate" function, I wouldn't expect validation to mutate the config.
There was a problem hiding this comment.
Good point, I wasn't sure how the condition field would be set if it isn't passed in from the config, but I see now with some testing that it gets set to the default. Change has been pushed 👍
BinaryFissionGames
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Change
Adds OTTL Metric Condition, Statement, and Expression to the expr package. Changes the sampling processor to use a metric based condition instead of datapoint based condition.
Followup to: #1877
Checklist