chore: Remove logging.yaml #1809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpaasman00
force-pushed
the
chore/remove-logging.yaml
branch
from
ac92663 to
a8bdd95
Compare
dpaasman00
requested review from
jsirianni and
justinianvoss22
and removed request for
justinianvoss22
jsirianni
requested changes
Aug 26, 2024
| @@ -263,7 +252,6 @@ dockers: | |||
| extra_files: | |||
| - release_deps/VERSION.txt | |||
| - release_deps/plugins | |||
| - config/logging.stdout.yaml | |||
There was a problem hiding this comment.
Will containers continue to log to stdout / error?
There was a problem hiding this comment.
Unsure about containers. All I know is the supervisor starts the agent as it's own subprocess and directs output from stdout to a file called agent.log. I'm not sure what that means for containers...
There was a problem hiding this comment.
I think this should be a blocker that we resolve before cutting over to v2. Logging to a file within the container will be a no go.
To be clear, it does not need to block this PR, but we do need to track this as an issue.
jsirianni
approved these changes
Aug 28, 2024
dpaasman00
added a commit
that referenced
this pull request
Sep 11, 2024
* remove logging.yaml * remove logging files
dpaasman00
added a commit
that referenced
this pull request
Oct 7, 2024
* remove logging.yaml * remove logging files
dpaasman00
added a commit
that referenced
this pull request
Nov 14, 2024
* remove logging.yaml * remove logging files
dpaasman00
added a commit
that referenced
this pull request
Dec 9, 2024
* remove logging.yaml * remove logging files
dpaasman00
added a commit
that referenced
this pull request
Dec 16, 2024
* remove logging.yaml * remove logging files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Change
Cleanup references to
logging.yamlChecklist