Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RAT processor only copying to first metric #159

Merged
merged 2 commits into from
Jan 11, 2022
Merged

Fix RAT processor only copying to first metric #159

merged 2 commits into from
Jan 11, 2022

Conversation

BinaryFissionGames
Copy link
Contributor

Proposed Change

  • Fix incorrect loop variable being used in loop, which made only the first metric in the ResourceMetrics take the value of the resource.
  • Add a unit test for this scenario.
Checklist
  • Changes are tested
  • Changes are documented

@BinaryFissionGames BinaryFissionGames requested a review from a team as a code owner January 11, 2022 18:03
@BinaryFissionGames BinaryFissionGames merged commit 4cb1c86 into master Jan 11, 2022
@BinaryFissionGames BinaryFissionGames deleted the fix-rat-proc branch January 11, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmwilliams89 jmwilliams89 jmwilliams89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BinaryFissionGames @jmwilliams89