feat: Add filelog.mtimeSortType feature flag #1339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpheps
approved these changes
Nov 14, 2023
antonblock
approved these changes
Nov 14, 2023
|
This won't work with v0.88.0, we need to wait until v0.89.0 (I missed that the release cycle was skipped for kubecon, I think) |
BinaryFissionGames
force-pushed
the
feat/add-sort-by-mtime-feature
branch
from
92f0ddc to
d6f720c
Compare
BinaryFissionGames
force-pushed
the
feat/add-sort-by-mtime-feature
branch
from
d6f720c to
557f375
Compare
cpheps
pushed a commit
that referenced
this pull request
Nov 28, 2023
* Added all component modules to dependabot (#1337) * Added all component modules to dependabot Signed-off-by: Corbin Phelps <[email protected]> * Added chronicle Signed-off-by: Corbin Phelps <[email protected]> --------- Signed-off-by: Corbin Phelps <[email protected]> * Updated module version Signed-off-by: Corbin Phelps <[email protected]> * fix: Put Chronicle into its own module (#1346) * Updated module version Signed-off-by: Corbin Phelps <[email protected]> * Move chronicle into its own module * Set Chroncile to v0.40.0 --------- Signed-off-by: Corbin Phelps <[email protected]> Co-authored-by: Corbin Phelps <[email protected]> * feat(otel): Updated to otel v0.89.0 (#1350) * Updated to otel v0.89.0 Signed-off-by: Corbin Phelps <[email protected]> * Removed unused replace in go.mod Signed-off-by: Corbin Phelps <[email protected]> --------- Signed-off-by: Corbin Phelps <[email protected]> * feat(service): SysV init.d style startup script (#1347) * Adding a SysV init.d startup script * Fix missing quotes from bad copy/paste * Addressed feedback (shellcheck) issues and added user support * Commenting on how to run as non-root, and correcting variable assignment * Change env variable name to the proper RUNUSER instead of USER * Add missing quotes * Update comment about RUNUSER * add clarity that root is the default user * Add HTTP Check Receiver (#1349) * added httpcheck receiver * updated go mod tidy * pseudo-rebase * chore: Tooling Updates (#1352) * Updated tools and ran ci-checks Signed-off-by: Corbin Phelps <[email protected]> * Updated github actions Signed-off-by: Corbin Phelps <[email protected]> * Tried setting cache to false Signed-off-by: Corbin Phelps <[email protected]> * Cleaned up cache references add go-cmp to install-tools Signed-off-by: Corbin Phelps <[email protected]> * Try rearranging install order Signed-off-by: Corbin Phelps <[email protected]> * Reorganized checks Signed-off-by: Corbin Phelps <[email protected]> * Made tool checks on go 1.21 Signed-off-by: Corbin Phelps <[email protected]> * Removed install tools from release.ymla nd just added cosign version Signed-off-by: Corbin Phelps <[email protected]> --------- Signed-off-by: Corbin Phelps <[email protected]> * feat: Added syslog exporter (#1354) Added syslog exporter Signed-off-by: Corbin Phelps <[email protected]> * fix: Chronicle creds (#1353) Fix chronicle creds * deps: Dependabot 11-27-2023 (#1360) * Updated golang.org/x/oauth2 to v0.11.0 Signed-off-by: Corbin Phelps <[email protected]> * Updated github.com/antonmedv/expr to v1.15.4 Signed-off-by: Corbin Phelps <[email protected]> * Updated google.golang.org/api to v0.151.0 Signed-off-by: Corbin Phelps <[email protected]> * Excluded go.opentelemetry.io dependencies from dependabot Signed-off-by: Corbin Phelps <[email protected]> * Updated github.com/Azure/azure-sdk-for-go/sdk/storage/azblob to v1.2.0 Signed-off-by: Corbin Phelps <[email protected]> * Updated github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/collector to v0.45.0 Signed-off-by: Corbin Phelps <[email protected]> --------- Signed-off-by: Corbin Phelps <[email protected]> * feat: Add filelog.mtimeSortType feature flag (#1339) add filelog.mtimeSortType feature flag * feat: Override chronicle log type (#1359) * Auto detect log_type * Fix default config test * Continue on failed to marshal & Use observed timestamp when timestamp not set * Docs * Use errrors.new --------- Signed-off-by: Corbin Phelps <[email protected]> Co-authored-by: Miguel Rodriguez <[email protected]> Co-authored-by: Dylan Myers <[email protected]> Co-authored-by: Bomin Rahmani <[email protected]> Co-authored-by: Brandon Johnson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Change
filelog.mtimeSortTypefeature flag, which enables using themtimesort type in the filelog'sordering_criteriasection.Checklist