feat: add sendgrid bundle for sending emails #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njhale
requested review from
ibuildthecloud,
drpebcak,
thedadams,
StrongMonkey,
iwilltry42,
ryanhopperlowe and
g-linville
njhale
force-pushed
the
feat/sendgrid-mvp
branch
3 times, most recently
from
0d8b94c to
d73255a
Compare
|
works after sendgrid email verification. |
g-linville
requested changes
Dec 26, 2024
sendgrid/cmd/send.go
Outdated
Comment on lines
14
to
23
| // Retrieve and trim environment variables | ||
| sendGridAPIKey := strings.TrimSpace(os.Getenv("SENDGRID_API_KEY")) | ||
| if sendGridAPIKey == "" { | ||
| return "", fmt.Errorf("SENDGRID_API_KEY is not set") | ||
| } | ||
|
|
||
| fromName := strings.TrimSpace(os.Getenv("SENDGRID_FROM_NAME")) | ||
| if fromName == "" { | ||
| return "", fmt.Errorf("SENDGRID_FROM_NAME is not set") | ||
| } | ||
|
|
||
| fromEmail := strings.TrimSpace(os.Getenv("SENDGRID_FROM_EMAIL")) | ||
| if fromEmail == "" { | ||
| return "", fmt.Errorf("SENDGRID_FROM_EMAIL is not set") | ||
| } |
There was a problem hiding this comment.
Are these supposed to come from a credential tool? There is no credential tool referenced in the tool.gpt file.
There was a problem hiding this comment.
Yeah, this is going to be updated shortly
There was a problem hiding this comment.
Updated to use credentials tool.
njhale
force-pushed
the
feat/sendgrid-mvp
branch
3 times, most recently
from
6aef696 to
a7a6c66
Compare
Signed-off-by: Nick Hale <[email protected]>
njhale
force-pushed
the
feat/sendgrid-mvp
branch
from
a7a6c66 to
4e12496
Compare
g-linville
approved these changes
Dec 31, 2024
| @@ -0,0 +1,6 @@ | |||
|
|
|||
StrongMonkey
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on obot-platform/obot#1086
Addresses obot-platform/obot#918