Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add a development explainer #930

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

thedadams
Copy link
Contributor

@thedadams thedadams commented Dec 17, 2024

This change also adds a docker build step to CI and adds the http/ directory to the gitignore.

Issue: #909

Now, any time one of these tools is run, your local copy will be used.

> [!IMPORTANT]
> Any time you change a Go based tool in your local repo, you must run `make build` in the tools repo for the changes to take effect with Obot.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well I usually only build that binary specifically for the tool I care instead of building all of it.

Copy link
Contributor

@ryanhopperlowe ryanhopperlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

Copy link
Contributor

@g-linville g-linville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some docs nits

DEVELOPMENT.md Outdated

## Debugging Obot

It is possible to run the server and/or UIs in and IDE for debugging purposes. These steps layout what is necessary for Jet Brains IDEs, but an equivalent process can be used with VSCode based editors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny nits

Suggested change
It is possible to run the server and/or UIs in and IDE for debugging purposes. These steps layout what is necessary for Jet Brains IDEs, but an equivalent process can be used with VSCode based editors.
It is possible to run the server and/or UIs in and IDE for debugging purposes. These steps layout what is necessary for JetBrains IDEs, but an equivalent process can be used with VSCode-based editors.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

DEVELOPMENT.md Outdated

### Admin UI

To run the Admin UI in GoLand or Web Storm:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny nit:

Suggested change
To run the Admin UI in GoLand or Web Storm:
To run the Admin UI in GoLand or WebStorm:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

DEVELOPMENT.md Outdated

### User UI

To run the User UI in GoLand or Web Storm:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny nit:

Suggested change
To run the User UI in GoLand or Web Storm:
To run the User UI in GoLand or WebStorm:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

DEVELOPMENT.md Outdated

## Obot Credentials

The GPTScript credentials for Obot are, by default, store in an SQLite database called `obot-credentials.db` in the root of the obot repo. You can use the `sqlite3` CLI to inspect the database directly: `sqlite3 obot-credentials.db`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The GPTScript credentials for Obot are, by default, store in an SQLite database called `obot-credentials.db` in the root of the obot repo. You can use the `sqlite3` CLI to inspect the database directly: `sqlite3 obot-credentials.db`.
The GPTScript credentials for Obot are, by default, stored in a SQLite database called `obot-credentials.db` in the root of the obot repo. You can use the `sqlite3` CLI to inspect the database directly: `sqlite3 obot-credentials.db`.

I know it's probably technically pronounced "S Q lite", but I'm pretty sure most people just say "sequelite".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

- name: Setup Depot
uses: depot/setup-action@v1

- name: Build and push Docker image
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for myself to fix this

Suggested change
- name: Build and push Docker image
- name: Build Docker Image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

This change also adds a docker build step to CI and adds the http/
directory to the gitignore.

Signed-off-by: Donnie Adams <[email protected]>
@thedadams thedadams merged commit f6d14a7 into obot-platform:main Dec 18, 2024
2 checks passed
@thedadams thedadams deleted the development-md branch December 18, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants