Chore/admin/update-breadcrumb-logic #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanhopperlowe
requested review from
ivyjeong13,
thedadams,
njhale,
StrongMonkey and
g-linville
ryanhopperlowe
force-pushed
the
chore/admin/update-breadcrumb-logic
branch
from
edc9b22 to
408a540
Compare
ivyjeong13
reviewed
Dec 13, 2024
| @@ -60,196 +87,11 @@ function RouteBreadcrumbs() { | |||
| <Link to={$path("/")}>Home</Link> | |||
| </BreadcrumbLink> | |||
| </BreadcrumbItem> | |||
| <BreadcrumbSeparator /> | |||
|
|
|||
| {routeInfo?.path === "/agents/:agent" && ( | |||
ivyjeong13
previously approved these changes
Dec 13, 2024
Screen.Recording.2024-12-13.at.1.54.23.PM.movOh noticed one small thing just wanted to verify! Should the Threads breadcrumb be there if I click a thread? |
Yes, nice catch! |
- determines which fields should be displayed as passwords when configuring a model provider
ryanhopperlowe
force-pushed
the
chore/admin/update-breadcrumb-logic
branch
from
408a540 to
38d546e
Compare
ivyjeong13
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves breadcrumb logic by using Remix Route Handles.
further reading for context:
https://remix.run/docs/zh/main/guides/breadcrumbs