feat: sort models by name in default model dropdowns #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanhopperlowe
commented
Dec 6, 2024
| @@ -12,7 +12,7 @@ type ModelManifest struct { | |||
| ModelProvider string `json:"modelProvider,omitempty"` | |||
| Alias string `json:"alias,omitempty"` | |||
| Active bool `json:"active"` | |||
| Usage ModelUsage `json:"usage,omitempty"` | |||
| Usage ModelUsage `json:"usage"` | |||
There was a problem hiding this comment.
Made this change so the frontend can map to the backend response via enum
There was a problem hiding this comment.
im explicitly OKing this. We'll see if a real dev yells at me later.
ryanhopperlowe
requested review from
thedadams,
ivyjeong13,
njhale,
StrongMonkey and
g-linville
ivyjeong13
approved these changes
Dec 6, 2024
- sorts models by name in default model dropdowns - adds an "Other" group to dropdowns for models that don't have a usage - ensures that backend always returns a value for model usage Signed-off-by: Ryan Hopper-Lowe <[email protected]>
Signed-off-by: Ryan Hopper-Lowe <[email protected]>
ryanhopperlowe
force-pushed
the
feat/admin/update-default-model-details
branch
from
a02efb1 to
2f50107
Compare
cjellick
approved these changes
Dec 6, 2024
ivyjeong13
reviewed
Dec 6, 2024
| getModelUsageFromAlias(alias) ?? | ||
| ModelUsage.Unknown; | ||
|
|
||
| const modelOptions = filterModelsByUsage( |
There was a problem hiding this comment.
nit: Just a thought but wondering if a usage is set, should the options show both ones marked as usage and the unknowns? In case a type is set for one, but maybe a user wanted to find one of the unknowns?
There was a problem hiding this comment.
check the renderSelectModelContent method :)
ivyjeong13
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryan Hopper-Lowe [email protected]