Make text-embedding-3-large the default embedding model #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedadams
approved these changes
Dec 5, 2024
| @@ -25,7 +25,7 @@ items: | |||
| spec: | |||
| manifest: | |||
| alias: text-embedding | |||
| model: text-embedding-3-small | |||
| model: text-embedding-3-large | |||
There was a problem hiding this comment.
This won't update currently deployed environments, but this is the right change.
iwilltry42
approved these changes
Dec 5, 2024
|
@thedadams will this change be nullified by the model changes you and ivy are making? |
|
If I understand correctly, for OpenAI, we were still going to hard-code the suggested default models. This would need to be included there. I guess the point is: after today, this change will no longer achieve its goal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
text-embedding-3-large is much better than text-embedding-3-small. It should be the default embedding model.
pgvector does have a max dim limit of 2000 so the following changes are necessary before merging this PR in: obot-platform/tools#258