-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Model Providers page #774
Merged
ivyjeong13
merged 1 commit into
obot-platform:main
from
ivyjeong13:feat/model-providers-page
Dec 5, 2024
Merged
feat: Model Providers page #774
ivyjeong13
merged 1 commit into
obot-platform:main
from
ivyjeong13:feat/model-providers-page
Dec 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivyjeong13
force-pushed
the
feat/model-providers-page
branch
3 times, most recently
from
December 5, 2024 00:09
09c0670
to
4f4f7af
Compare
ivyjeong13
force-pushed
the
feat/model-providers-page
branch
2 times, most recently
from
December 5, 2024 15:01
f4cac92
to
3c00a10
Compare
ivyjeong13
requested review from
ryanhopperlowe,
njhale,
StrongMonkey and
g-linville
December 5, 2024 15:03
ui/admin/app/components/model-providers/ModelProviderConfigure.tsx
Outdated
Show resolved
Hide resolved
ui/admin/app/components/model-providers/ModelProviderContext.tsx
Outdated
Show resolved
Hide resolved
ui/admin/app/components/model-providers/ModelProviderContext.tsx
Outdated
Show resolved
Hide resolved
ryanhopperlowe
requested changes
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple of things to fix here, but good overall!
ivyjeong13
force-pushed
the
feat/model-providers-page
branch
from
December 5, 2024 16:40
3c00a10
to
83fa4be
Compare
ryanhopperlowe
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 🙌
chore: remove ModelProviderContext chore: minor cleanup changes
ivyjeong13
force-pushed
the
feat/model-providers-page
branch
from
December 5, 2024 17:31
27c9ded
to
be39b17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2024-12-05.at.10.05.22.AM.mov
Models Provider Page!