Fix: fix delete knowledge source hanging in UI

[StrongMonkey]

Don't list knowledge source with deleted as it could be waiting to be cleaned by finalizer. Also validate in cache after deletion.

#746

[ryanhopperlowe]

when performing mutations on swr fetchers, please pull out the mutation into it's own useMemo.

If I were to try to use this key again with the generic fetcher method, my code would break because the data from the response would not align with the data in the cache

[ryanhopperlowe]

example

// wrong

const { data }  = useSWR(
    Service.method.key(),
    () => Service.method().then(() => someMutation()) // cache has mutated data
)

// in another file

const { data }  = useSWR(
    Service.method.key(),
    () => Service.method() // cache has data directly from response
)

// an error may be thrown because the data in the cache does not match the structure of the data from the response

instead do this:

const { data }  = useSWR(
    Service.method.key(),
    () => Service.method() // use data directly from response
)

const mutatedData = useMemo(() => someMutation(data), [data])

// in another file

const { data }  = useSWR(
    Service.method.key(),
    () => Service.method() // also use data directly from response
)


No error now, because the data in the cache will ALWAYS have the same structure

[ryanhopperlowe]

Happy to hop on a huddle and explain in more depth if necessary :)

[StrongMonkey]

Good to know! changed 👍

[ryanhopperlowe]

It's ugly, but it's important... If I ever get the time to replace SWR with react-query, this will be super trivial

[ryanhopperlowe]

thanks for fixing that!