fix: display error if tool creation failed #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivyjeong13
requested review from
ryanhopperlowe,
njhale,
StrongMonkey and
g-linville
ivyjeong13
force-pushed
the
fix/error-tool-creation
branch
from
c573ee2 to
3231a6a
Compare
Update CreateTool.tsx
ivyjeong13
force-pushed
the
fix/error-tool-creation
branch
from
3231a6a to
548a9bf
Compare
ryanhopperlowe
requested changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #502
After syncing with Donnie,
resolvedfield was added to the ToolReference. Similarly toaliasAssigned:undefined, the creation of tool is still resolvingtrue/false, tool has or has not been resolvedOnce resolved,
errorshould be supplied.Needed to implement polling to fetch the ToolReference until it is resolved.
Once resolved, error is shown in ErrorDialog, but lemme know if there is a different preferred error handling!
Screen.Recording.2024-12-03.at.10.13.18.AM.mov
(Tempted to see if I can make it scroll to the created tool once it's completed so user immediately sees their uploaded tool or maybe sort by recently created so it immediately shows at the top?)