Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve dev environment setup for admin ui #731

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/admin.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,11 @@ jobs:
with:
version: 9.12.3

- name: Install dependencies
- name: Install and Build
run: |
cd ui/admin
pnpm install
pnpm run build

- name: Run linter
run: make lint-admin
Expand Down
5 changes: 5 additions & 0 deletions ui/admin/app/lib/service/routeService.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@ import queryString from "query-string";
import { $params, $path, Routes, RoutesWithParams } from "remix-routes";
import { ZodNull, ZodSchema, ZodType, z } from "zod";

// note: If you see a linter error related to `Routes`, or `RoutesWithParams`,
// it's probably because you need to run `pnpm run dev` or `pnpm run build`
// these types are generated by remix-routes, and are used to provide type
// safety when navigating through the app

const QuerySchemas = {
agentSchema: z.object({
threadId: z.string().nullish(),
Expand Down
3 changes: 1 addition & 2 deletions ui/admin/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@
"dev": "remix vite:dev",
"lint": "eslint --ignore-path .gitignore --cache --cache-location ./node_modules/.cache/eslint . && tsc --noEmit",
"preview": "vite preview",
"format": "prettier --write .",
"postinstall": "npm run build"
"format": "prettier --write ."
},
"dependencies": {
"@gptscript-ai/gptscript": "^0.9.5-rc5",
Expand Down