fix: prevent event source from reconnecting after SSE close event #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanhopperlowe
requested review from
g-linville,
ivyjeong13,
njhale,
StrongMonkey and
thedadams
StrongMonkey
approved these changes
Dec 2, 2024
ryanhopperlowe
deleted the
fix/admin/prevent-extra-requests-on-sse-close
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a workflow (or workflow authentication) was completed, the Server would close it's connection to the SSE, but the UI never closed the EventSource and would repeatedly attempt to reconnect causing a new api request every few seconds. This fix alleviates this by closing the connection in the UI whenever the server sends a
closeevent