Fix: fix fe code to not make requests when validating cache #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daishan Peng <[email protected]>
StrongMonkey
requested review from
thedadams,
njhale,
iwilltry42,
ryanhopperlowe and
g-linville
ryanhopperlowe
approved these changes
Nov 28, 2024
iwilltry42
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't make API requests when manually validating cache data. This is causing problem when ingesting large amount of files, as it is making too many requests in the server which cause server to load up. The knowledge files are stored in a same database withe
defaultnamespace so there is no index when retrieving them from database.Also cut the interval from 1 second to 5 seconds to avoid putting too much load to server.
https://github.com/otto8-ai/otto8/issues/558