Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: minor ToolCard styling change #710

Merged
merged 1 commit into from
Nov 27, 2024
Merged

fix: minor ToolCard styling change #710

merged 1 commit into from
Nov 27, 2024

Conversation

ivyjeong13
Copy link
Contributor

@ivyjeong13 ivyjeong13 commented Nov 27, 2024 •
edited
Loading

  • minor update to avoid chip being cut off and icon being shrunk as browser is resized
  • instead of margins, removed and used gap-2 so if the chip / "Bundle" is moved to a new line, its left side is still aligned with the above line

Before:

Screen.Recording.2024-11-26.at.3.00.33.PM.mov

After:

Screen.Recording.2024-11-26.at.2.59.55.PM.mov

@ivyjeong13 ivyjeong13 force-pushed the fix/minor-tool-card-styling-update branch 3 times, most recently from e2561c2 to d56cf49 Compare November 27, 2024 16:19
ryanhopperlowe
ryanhopperlowe approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@ryanhopperlowe ryanhopperlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 Nice find! Love removing 1-off margins/padding

@ivyjeong13 ivyjeong13 force-pushed the fix/minor-tool-card-styling-update branch from d56cf49 to a63a1d8 Compare November 27, 2024 20:42
@ivyjeong13 ivyjeong13 merged commit 4846fd8 into obot-platform:main Nov 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanhopperlowe ryanhopperlowe ryanhopperlowe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivyjeong13 @ryanhopperlowe