Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Publish URL showing based on aliasAssigned and entityID check #693

Merged
merged 2 commits into from
Nov 26, 2024
Merged

fix: Publish URL showing based on aliasAssigned and entityID check #693

merged 2 commits into from
Nov 26, 2024

Conversation

ivyjeong13
Copy link
Contributor

This addresses issue 634.

  • checks against entityID instead of id.
  • updates AgentContext to return agent from getAgent.data or default to the agent supplied from clientLoader.
  • updates agentUpdates with appropriate aliasAssigned when agent is updated.

@ivyjeong13 ivyjeong13 force-pushed the fix/publish-agent-url-display-correctly branch from c1a5bf3 to f49a6eb Compare November 26, 2024 19:23
@ivyjeong13 ivyjeong13 merged commit 5c4d37e into obot-platform:main Nov 26, 2024
1 check passed
@ivyjeong13 ivyjeong13 deleted the fix/publish-agent-url-display-correctly branch November 26, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanhopperlowe ryanhopperlowe ryanhopperlowe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivyjeong13 @ryanhopperlowe