feat: overhaul agent edit UX #254
Conversation
tylerslaton
force-pushed
the
overhaul-agent-edit
branch
from
8ac9adb to
ea539bd
Compare
|
@ryanhopperlowe Addressed your comments and introduced a lot of new code. Mind giving it another look? |
tylerslaton
force-pushed
the
overhaul-agent-edit
branch
from
ea539bd to
6fef2d2
Compare
This is a pretty substantial overhaul of the agent edit UX. The main changes are: - A new "Advanced" tab that allows you to edit the prompt - The name and description now look like contentEditable fields (they're not, but they act like them) - The edit agent page has moved the "go back" button to the header - New "Knowledge" suggestion for preview chats - Updated "restart chat" button to be "new thread" along with a companion button to select past threads - Accordion options now have color, descriptions, and larger text. - New Agents now have a name of "New Agent" instead of the fun random names they used to have. Signed-off-by: tylerslaton <[email protected]>
tylerslaton
force-pushed
the
overhaul-agent-edit
branch
from
6fef2d2 to
8329811
Compare
| <Popover open={open} onOpenChange={handleOpenChange}> | ||
| <PopoverTrigger asChild> | ||
| <Button variant="secondary" size="icon"> | ||
| <ChevronUpIcon className="w-4 h-4" /> |
There was a problem hiding this comment.
can you add text here to indicate past threads?
There was a problem hiding this comment.
I would prefer a tool tip, what do you think? Otherwise things get a bit crowded.
There was a problem hiding this comment.
Either is fine with me. Just some sort of indicator would be nice
| export const agentEditParamSchema = z.object({ | ||
| from: z.string().optional(), | ||
| }); |
There was a problem hiding this comment.
| export const agentEditParamSchema = z.object({ | |
| from: z.string().optional(), | |
| }); | |
| const paramSchema = QueryParamService.Agents; | |
| export type SearchParams = z.infer<typeof paramSchema>; |
There was a problem hiding this comment.
didn't see this fix
There was a problem hiding this comment.
I just forgot to delete this, I'm not actually using it since its defined in the QueryParamSchemas
Signed-off-by: tylerslaton <[email protected]>
tylerslaton
force-pushed
the
overhaul-agent-edit
branch
from
a0a125a to
2f7155c
Compare
|
@ryanhopperlowe I addressed all of your comments except for the first one, if you'd like lets meet so I can understand why we should do that instead of what we have now. |
| <Popover open={open} onOpenChange={handleOpenChange}> | ||
| <PopoverTrigger asChild> | ||
| <Button variant="secondary" size="icon"> | ||
| <ChevronUpIcon className="w-4 h-4" /> |
There was a problem hiding this comment.
Either is fine with me. Just some sort of indicator would be nice
tylerslaton
force-pushed
the
overhaul-agent-edit
branch
from
2f7155c to
e64664d
Compare
Signed-off-by: tylerslaton <[email protected]>
tylerslaton
force-pushed
the
overhaul-agent-edit
branch
from
e64664d to
7ac2d2e
Compare
This is a pretty substantial overhaul of the agent
edit UX. The main changes are:
prompt
fields (they're not, but they act like them)
to the header
along with a companion button to select past threads
larger text.
the fun random names they used to have.
Screen.Recording.2024-10-22.at.11.56.00.AM.mov