fix: remove id from event stream messages #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedadams
reviewed
Oct 17, 2024
ui/admin/app/lib/stream.ts
Outdated
| @@ -39,7 +39,10 @@ export async function readStream<T>({ | |||
|
|
|||
| // Process complete messages | |||
| for (const message of messages) { | |||
| const dataString = message.replace(/^data: /, "").trim(); | |||
| const dataString = message | |||
| .replace(/^(.*)\n/, "") | |||
There was a problem hiding this comment.
Let's be a little more careful here. And we don't need the capture.
Suggested change
| .replace(/^(.*)\n/, "") | |
| .replace(/^id.*$/, "") |
There was a problem hiding this comment.
Had to adjust this recommendation a bit but removed the capture.
This is a fix for issue #223. The event stream for messages included a new id entry that was not expected by the client. Signed-off-by: tylerslaton <[email protected]>
thedadams
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for issue #223. The event stream for messages included a new id entry that was not
expected by the client.