Add req sonners #192
Merged
Add req sonners #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tylerslaton <[email protected]>
Signed-off-by: tylerslaton <[email protected]>
tylerslaton
force-pushed
the
add-req-sonners
branch
from
cd7492c to
a2c2fc2
Compare
Signed-off-by: tylerslaton <[email protected]>
ryanhopperlowe
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds in request sonners. Essentially, we now get notifications in the UI whenever an error occurs in a API request. This happens generically to ensure it always happens. In addition, each request can specify its own error message which this PR adds for every request. They end-up looking like this.
Note: The sonner version is pinned since the latest, 1.5, is breaking styles for shadcn. This is documented in their repo.