Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set the correct credential tool for tool reference #1020

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

thedadams
Copy link
Contributor

There were a couple issues. First, since we are using the url package, the credential tool was path-escaped. This change fixes that.

Secondly, the credential set here was not usable by GPTScript if the reference was of the form "sub tool from path/to/tool". This change also addresses that by parsing the tool reference.

There were a couple issues. First, since we are using the url package,
the credential tool was path-escaped. This change fixes that.

Secondly, the credential set here was not usable by GPTScript if the
reference was of the form "sub tool from path/to/tool". This change also
addresses that by parsing the tool reference.

Signed-off-by: Donnie Adams <[email protected]>
@thedadams thedadams merged commit 31c39b7 into obot-platform:main Dec 23, 2024
2 checks passed
@thedadams thedadams deleted the fix-cred-reference branch December 23, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants