Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/admin/thread-knowledge #1016

Merged

Conversation

ryanhopperlowe
Copy link
Contributor

@ryanhopperlowe ryanhopperlowe commented Dec 20, 2024

This PR further abstracts the knowledge api code to make it reusable between various namespaces (agents, threads, workflows)

it also renames the thread knowledge apis to knowledge-files in the backend

This makes it possible to quickly add thread level knowledge without having to reinvent the wheel. (accomplished in this PR)

Screenshot 2024-12-20 at 4 56 22 PM

Also disables thread level knowledge if the knowledge tool is not enabled at the agent level

Screenshot 2024-12-20 at 4 57 27 PM

Copy link
Contributor

@ivyjeong13 ivyjeong13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frontend changes LGTM! 👍

…dge namespaces (agents, workflows, threads)

Signed-off-by: Ryan Hopper-Lowe <[email protected]>
Helps to differentiate between what entities can pull from knowledge files vs knowledge sources
@ryanhopperlowe ryanhopperlowe force-pushed the feat/admin/thread-knowledge branch from eed88ab to b2f0044 Compare December 30, 2024 15:04
@ryanhopperlowe ryanhopperlowe merged commit 0a747bb into obot-platform:main Dec 30, 2024
3 checks passed
@ryanhopperlowe ryanhopperlowe deleted the feat/admin/thread-knowledge branch December 30, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants