fix: set aliases as unassigned on changes or deletes

Signed-off-by: Donnie Adams <[email protected]>

pkg/controller/handlers/alias/alias.go

@@ -27,6 +27,11 @@ func AssignAlias(req router.Request, _ router.Response) error {
 	aliasable := req.Object.(v1.Aliasable)
 
 	if aliasable.GetAliasName() == "" {
+		if aliasable.IsAssigned() {
+			aliasable.SetAssigned(false)
+			return req.Client.Status().Update(req.Ctx, req.Object)
+		}
+
 		return nil
 	}
 
@@ -56,12 +61,8 @@ func AssignAlias(req router.Request, _ router.Response) error {
 		return err
 	}
 
-	if !matches(alias, req.Object) {
-		return nil
-	}
-
-	if !aliasable.IsAssigned() {
-		aliasable.SetAssigned()
+	if assigned := matches(alias, req.Object); assigned != aliasable.IsAssigned() {
+		aliasable.SetAssigned(assigned)
 		return req.Client.Status().Update(req.Ctx, req.Object)
 	}
 

pkg/storage/apis/otto.otto8.ai/v1/agent.go

@@ -32,8 +32,8 @@ func (a *Agent) GetAliasName() string {
 	return a.Spec.Manifest.Alias
 }
 
-func (a *Agent) SetAssigned() {
-	a.Status.AliasAssigned = true
+func (a *Agent) SetAssigned(assigned bool) {
+	a.Status.AliasAssigned = assigned
 }
 
 func (a *Agent) Has(field string) bool {

pkg/storage/apis/otto.otto8.ai/v1/alias.go

@@ -43,7 +43,7 @@ type AliasSpec struct {
 
 type Aliasable interface {
 	GetAliasName() string
-	SetAssigned()
+	SetAssigned(bool)
 	IsAssigned() bool
 }
 

pkg/storage/apis/otto.otto8.ai/v1/emailaddress.go

@@ -24,8 +24,8 @@ func (in *EmailReceiver) GetAliasName() string {
 	return in.Spec.EmailReceiverManifest.User
 }
 
-func (in *EmailReceiver) SetAssigned() {
-	in.Status.AliasAssigned = true
+func (in *EmailReceiver) SetAssigned(assigned bool) {
+	in.Status.AliasAssigned = assigned
 }
 
 func (in *EmailReceiver) IsAssigned() bool {

pkg/storage/apis/otto.otto8.ai/v1/oauthapp.go

@@ -28,7 +28,7 @@ func (r *OAuthApp) GetAliasName() string {
 	return r.Spec.Manifest.Integration
 }
 
-func (r *OAuthApp) SetAssigned() {
+func (r *OAuthApp) SetAssigned(bool) {
 }
 
 func (r *OAuthApp) IsAssigned() bool {

pkg/storage/apis/otto.otto8.ai/v1/webhook.go

@@ -24,8 +24,8 @@ func (w *Webhook) GetAliasName() string {
 	return w.Spec.WebhookManifest.Alias
 }
 
-func (w *Webhook) SetAssigned() {
-	w.Status.AliasAssigned = true
+func (w *Webhook) SetAssigned(assigned bool) {
+	w.Status.AliasAssigned = assigned
 }
 
 func (w *Webhook) IsAssigned() bool {

pkg/storage/apis/otto.otto8.ai/v1/workflow.go

@@ -24,8 +24,8 @@ func (in *Workflow) GetAliasName() string {
 	return in.Spec.Manifest.Alias
 }
 
-func (in *Workflow) SetAssigned() {
-	in.Status.AliasAssigned = true
+func (in *Workflow) SetAssigned(assigned bool) {
+	in.Status.AliasAssigned = assigned
 }
 
 func (in *Workflow) IsAssigned() bool {