Address comments

Signed-off-by: Daishan Peng <[email protected]>
obot-platform · Oct 21, 2024 · 6a23daf · 6a23daf
1 parent aec42ac
commit 6a23daf
Show file tree

Hide file tree

Showing 3 changed files with 44 additions and 32 deletions.
diff --git a/ui/admin/app/components/knowledge/notion/NotionModal.tsx b/ui/admin/app/components/knowledge/notion/NotionModal.tsx
@@ -160,12 +160,16 @@ export const NotionModal: FC<NotionModalProps> = ({
                     </Button>
                 </div>
             </DialogContent>
-            <RemoteSourceSettingModal
-                agentId={agentId}
-                isOpen={isSettingModalOpen}
-                onOpenChange={setIsSettingModalOpen}
-                remoteKnowledgeSource={notionSource!}
-            />
+            {notionSource && (
+                <>
+                    <RemoteSourceSettingModal
+                        agentId={agentId}
+                        isOpen={isSettingModalOpen}
+                        onOpenChange={setIsSettingModalOpen}
+                        remoteKnowledgeSource={notionSource}
+                    />
+                </>
+            )}
         </Dialog>
     );
 };
diff --git a/ui/admin/app/components/knowledge/onedrive/OneDriveModal.tsx b/ui/admin/app/components/knowledge/onedrive/OneDriveModal.tsx
@@ -348,19 +348,23 @@ export const OnedriveModal: FC<OnedriveModalProps> = ({
                         Close
                     </Button>
                 </div>
-                <RemoteSourceSettingModal
-                    agentId={agentId}
-                    isOpen={isSettingModalOpen}
-                    onOpenChange={setIsSettingModalOpen}
-                    remoteKnowledgeSource={onedriveSource!}
-                />
-                <AddLinkModal
-                    agentId={agentId}
-                    onedriveSource={onedriveSource!}
-                    startPolling={startPolling}
-                    isOpen={isAddLinkModalOpen}
-                    onOpenChange={setIsAddLinkModalOpen}
-                />
+                {onedriveSource && (
+                    <>
+                        <RemoteSourceSettingModal
+                            agentId={agentId}
+                            isOpen={isSettingModalOpen}
+                            onOpenChange={setIsSettingModalOpen}
+                            remoteKnowledgeSource={onedriveSource}
+                        />
+                        <AddLinkModal
+                            agentId={agentId}
+                            onedriveSource={onedriveSource}
+                            startPolling={startPolling}
+                            isOpen={isAddLinkModalOpen}
+                            onOpenChange={setIsAddLinkModalOpen}
+                        />
+                    </>
+                )}
             </DialogContent>
         </Dialog>
     );

diff --git a/ui/admin/app/components/knowledge/website/WebsiteModal.tsx b/ui/admin/app/components/knowledge/website/WebsiteModal.tsx
@@ -261,19 +261,23 @@ export const WebsiteModal: FC<WebsiteModalProps> = ({
                         Close
                     </Button>
                 </div>
-                <RemoteSourceSettingModal
-                    agentId={agentId}
-                    isOpen={isSettingModalOpen}
-                    onOpenChange={setIsSettingModalOpen}
-                    remoteKnowledgeSource={websiteSource!}
-                />
-                <AddWebsiteModal
-                    agentId={agentId}
-                    websiteSource={websiteSource!}
-                    startPolling={startPolling}
-                    isOpen={isAddWebsiteModalOpen}
-                    onOpenChange={setIsAddWebsiteModalOpen}
-                />
+                {websiteSource && (
+                    <>
+                        <RemoteSourceSettingModal
+                            agentId={agentId}
+                            isOpen={isSettingModalOpen}
+                            onOpenChange={setIsSettingModalOpen}
+                            remoteKnowledgeSource={websiteSource}
+                        />
+                        <AddWebsiteModal
+                            agentId={agentId}
+                            websiteSource={websiteSource}
+                            startPolling={startPolling}
+                            isOpen={isAddWebsiteModalOpen}
+                            onOpenChange={setIsAddWebsiteModalOpen}
+                        />
+                    </>
+                )}
             </DialogContent>
         </Dialog>
     );