-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only lead climbs #60
Open
pectum83
wants to merge
11
commits into
oblyk:master
Choose a base branch
from
pectum83:onlyLeadClimbs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Only lead climbs #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucien-chastan
added
enhancement
New feature or request
outdoor
tag for the outdoor part
labels
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Et voilà pour les commentaires sur la partie front !
Est-ce que tu pourra mettre une capture d'écran ? ça permet d'imager la PR : )
# Conflicts: # package-lock.json # package.json
… one crag, icon were sames and false. Added cragRoute props and also added ascent_status and roping_status in backend api ascended_crag_routes
Replaced `onlyLeadClimbs` with a more flexible `filters` system across outdoor ascents, analytics, and related components. Introduced a method to dynamically generate filter parameters, updated UI elements to handle multiple filters, and adjusted API calls accordingly. Enhanced translation files to support new filter options.
…mplement filters for other users)
Voir les commentaires globaux api/app et les screenshots sur la PR api. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Evolution liée au ticket "croix en tete et/ou en moulinette #59" pour les deux points.
1 - Permet de n'afficher que les croix en tête avec un selecteur pour ceux qui veulent voir aussi les moulinettes.
2 - Ne compte pas les répétitions d'une même voie dans les croix
Corrige également : les grandes voies sont comptées comme croix dans le niveau max parmis les sections réalisées dans l'ascent (auparavant elles comptaient dans le niveau min de toutes les sections de la crag_route)
A combiner avec la pull request sur oblyk-api