Handle rapid changes to collapsed prop #233
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had an issue while using a collapsible that was to be collapsed while the keyboard was showing. When the device (iPhone X in this case) was rotated, the following series of events unfolds: 1. `KeyboardWillHide` event emitted 2. We pass `collapsed: false` to the `<Collapsible/>` 3. `_toggleCollapsed(false)` -> `_measureContent()` starts 4. `KeyboardWillShow` event emitted 5. We pass `collapsed: true` to the `<Collapsible/>` 6. `_toggleCollapsed(false)` -> `_transitionToHeight(0)` 7. measuring finishes 8. `_transitionToHeight(contentHeight)` is started due to callback from _measureContent 9. content now has a height, even though it has `collapsed: true` prop. I'm not altogether sure why on iOS react native fires the KeyboardWillHide and KeyboardWillShow events one after the other when the device is rotated, but that seems to be the case. The attached change makes the behaviour, instead of assuming that after measuring, the content should be shown uncollapsed; that after measuring the content should be shown in whatever state the collapsed property is once measuring is completed. Other than resolving my own issue it should work for other cases where the property changes rapidly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had an issue while using a collapsible that was to be collapsed while the keyboard was showing. When the device (iPhone X in this case) was rotated, the following series of events unfolds:
KeyboardWillHideevent emittedcollapsed: falseto the<Collapsible/>_toggleCollapsed(false)->_measureContent()startsKeyboardWillShowevent emittedcollapsed: trueto the<Collapsible/>_toggleCollapsed(false)->_transitionToHeight(0)_transitionToHeight(contentHeight)is started due to callback from _measureContentcollapsed: trueprop.I'm not altogether sure why on iOS react native fires the KeyboardWillHide and KeyboardWillShow events one after the other when the device is rotated, but that seems to be the case.
The attached change makes the behaviour, instead of assuming that after measuring, the content should be shown uncollapsed; that after measuring the content should be shown in whatever state the collapsed property is once measuring is completed. Other than resolving my own issue it should work for other cases where the property changes rapidly.