Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Increase code coverage for createAnimation #296

Merged
merged 2 commits into from
Nov 1, 2019
Merged

test: Increase code coverage for createAnimation #296

merged 2 commits into from
Nov 1, 2019

Conversation

haruelrovix
Copy link
Contributor 

> jest

 PASS  __tests__/getDefaultStyleValue.js
 PASS  __tests__/createAnimation.js
-------------------------|----------|----------|----------|----------|-------------------|
File                     |  % Stmts | % Branch |  % Funcs |  % Lines | Uncovered Line #s |
-------------------------|----------|----------|----------|----------|-------------------|
All files                |    90.67 |    83.02 |      100 |    90.28 |                   |
 createAnimation.js      |    92.86 |    85.19 |      100 |    92.68 |          44,47,61 |
 flattenStyle.js         |      100 |      100 |      100 |      100 |                   |
 getDefaultStyleValue.js |    84.62 |    79.17 |      100 |    83.33 |       16,19,25,28 |
-------------------------|----------|----------|----------|----------|-------------------|

Test Suites: 2 passed, 2 total
Tests:       10 passed, 10 total
Snapshots:   0 total
Time:        2.09s
Ran all test suites.
✨  Done in 5.25s.

oblador
oblador reviewed Oct 30, 2019
View reviewed changes
__tests__/createAnimation.js Outdated
}
const firstAnimation = createAnimation(definition)
const secondAnimation = createAnimation(definition)
expect(secondAnimation).toEqual(firstAnimation)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be toBe to test referential equality.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did I forget bout that...

@oblador
Copy link
Owner

oblador commented Oct 30, 2019

You’re a hero 😄

@oblador oblador merged commit 07401e6 into oblador:master Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oblador oblador oblador approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haruelrovix @oblador