Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Add more tests for hash-code-of object #206

Merged
merged 6 commits into from
Oct 9, 2023
Merged

Add more tests for hash-code-of object #206

merged 6 commits into from
Oct 9, 2023

Conversation

c71n93
Copy link
Member

@c71n93 c71n93 commented Oct 7, 2023

Closes #176


PR-Codex overview

This PR focuses on adding more tests for the hash-code-of object. The tests cover various scenarios including booleans, integers, big integers, strings, abstract objects, and floats.

Detailed summary

  • Renamed test hash-code-bools-is-integer to hash-code-of-bools-is-integer
  • Added tests for hashing booleans and integers
  • Added tests for hashing big integers
  • Added tests for hashing different integers
  • Added tests for hashing different sign integers
  • Added tests for hashing strings
  • Added tests for hashing different strings (disabled due to an issue)
  • Added tests for hashing abstract objects
  • Added tests for hashing different abstract objects
  • Added tests for hashing floats
  • Added tests for hashing different floats
  • Added tests for hashing different sign floats

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@c71n93
Copy link
Member Author

c71n93 commented Oct 9, 2023

@maxonfjvipon could you check this please?

Copy link
Member

@maxonfjvipon maxonfjvipon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@c71n93 nice one! Just a several comments from my side

src/test/eo/org/eolang/collections/hash-code-of-tests.eo Outdated Show resolved Hide resolved
src/test/eo/org/eolang/collections/hash-code-of-tests.eo Outdated Show resolved Hide resolved
Copy link
Member

@maxonfjvipon maxonfjvipon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@c71n93 LGTM! Thanks

@c71n93
Copy link
Member Author

c71n93 commented Oct 9, 2023

@yegor256 could you check, please?

@yegor256
Copy link
Member

yegor256 commented Oct 9, 2023

@rultor merge

@rultor
Copy link
Contributor

rultor commented Oct 9, 2023

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 6f68c18 into objectionary:master Oct 9, 2023
8 checks passed
@rultor
Copy link
Contributor

rultor commented Oct 9, 2023

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 12min)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hash-code-of-tests.eo:31-33: Add more tests for...
5 participants