Support for windows platform #78
Conversation
… handler When a client sends a GET request with Observe: 1, it must be removed from the list of observers before the resource handler is called. Otherwise, it will add an Observe option to its response.
This change introduces a new subtree in the library's directory structure. Platform-specific code now should be placed into the corresponding directory in src/platform/. To illustrate this, prng.h has been split into three distinct files, one for each platform (contiki, lwip, posix) and moved into the respective subdirectory.
Endpoints will be attached to the context object using a new function coap_attach_endpoint(). The sockfd component has been removed from coap_context_t as it is accessible by the endpoint. coap_endpoint_t has a new field 'context' that refers to the context object the respective endpoint has been associated with, or NULL if it is not attached to any context. An endpoint can be attached to at least one context at a time.
This modification provides two new functions, coap_run_once() and coap_run(), that can be used by applications to drive the library's I/O logic.
The prototypes for coap_attach_endpoint() and coap_detach_endpoint() were missing from this header file.
Non-blocking sockets can set COAP_ENDPOINT_HAS_DATA in flags to tell coap_read() that this endpoint has new data available for reading.
Making the posix sockets non-blocking was missing from coap_new_endpoint(). This wasn't much of a problem because recvmsg() was called only after select() had indicated that data is available. Setting this flag explicitly would also allow for peeking into the socket.
coap_dtls.h defines a generic API for DTLS communication. The initial version will use tinydtls as implementation.
coap_keystore.[hc] provides a simple data structure for managing credentials to be used during DTLS handshake. Each coap_context_t has its own keystore object that is independent of the actual DTLS context. Applications can access the keystore during the entire lifetime of the coap context. The existing implementation is not thread-safe.
The local endpoint object, peer address and data buffer address and length now are passed as arguments to coap_handle_message(). This change reverts a previous attempt to provide a more concise interface for this function that hides the actual implementation-specific data. As the DTLS implementation needs to deal with this implementation- specific parts, it has to be made explicit, either by making the packet abstraction public or passing the relevant parameters explicitely to coap_handle_message(). As this has worked smoothly before, this approach has been taken. This change breaks the LWIP implementation (for now). It will be fixed when integrating the DTLS code with LWIP in this branch.
The handling of DTLS sessions has been improved so that calling coap_dtls_send() buffers data for later delivery in case of a successful handshake.
An application can register a callback function of type coap_event_handler_t that will be called by the library on certain events. Currently, the DTLS implementation invokes coap_handle_event() with session-specific events such as session close or renegotiation.
coap_read_endpoint() should not be called when no data is available on the attached endpoint.
get_psk_info() now returns appropriate error codes.
The new option -u allows setting the user name (aka PSK identity) and -k is used to specify the corresponding secret (the PSK).
The example server creates a new endpoint for DTLS-secured traffic. The secure endpoint is bound to the port number of the unsecure port plus one (i.e. if the default port number 5683 is used for cleartext CoAP traffic, the secure port is bound to 5684). This server uses the credentials "Client_identity" as user name and "secretPSK" as password for testing. DO NOT USE THIS FOR PRODUCTION.
coap_send_impl() now decides if outbound data is passed to coap_dtls_send() or to the registered network_send callback function. For coap_send_confirmed() this implies that retransmitted PDUs are passed to coap_dtls_send() as well, causing retransmissions on the DTLS layer when the session is established. As long as the DTLS handshake is not complete, coap_dtls_send() caches the outbound application data for this particular PDU hence avoiding duplicate messages.
When a fatal error is detected for an ongoing DTLS session, any retransmission is stopped and the session object is released.
…pv6 sockets are implicitly dual-stacked on Linux by default, but not on Windows). Correctly map / unmap ipv4 addresses into ipv6 addresses so that ipv4 queries to an ipv6 dual-stacked server actually do work.
|
Okay, now I have a VS2017 up and running. It seems that I have to "retarget the toolset" (huh?) before it even starts trying to build the library. When I do this, it starts building uri.c for "Debug DLL x64" and then complains "fatal error C1083: Cannot open include file: 'coap_config.h': No such file or directory. (Sorry for the dumb newbie questions -- these IDE things just hide too much information about what is really going on...) |
|
The subdirectory |
|
The project files are for Visual Studio 2015. VS2017 is very widespread yet. It is possible to open VS2015 project files in VS2017 as is, they will appear with the mention (2015 project) next to them in the solution or to upgrade them to use the new toolchain of VS2017. Either should work. |
|
Good catch for the typo with coap-rd directory name. I will modify this and submit it as new change in the pull request. I will try with VS2017 as well. In the meantime you should still be able to build and test coap-rd. |
… unless you also have an x64 version of the CUnit library.
… dependent on the version of the kernel.
|
Thanks, I have managed to convince VS2017 to build the executables in And: I would have expected for |
|
To avoid confusion, especially with DLLs, I always add a 'd' suffix to librairies and executables from a debug build. Release builds don't have the suffix. This is a personal convention. Let me know if you want the suffix removed. By the way x64 builds should work as well now with df86b74, at least I have tested with coap-client and coap-server. |
|
Did you use the CUnit DLL built with VS2015 that I have included in the pull request ? You might have to change the PATH to make sure which one it's using or just copy the dll next to the executable. If you use one built with mingw you must make sure it was linked with the system's C library as a DLL (msvcrt.dll) to be interoperable. In VS2017, you can make testdriver the "startup project", modify the path in the "debug" options of the project if needed and run with F5 it to see the list of DLLs loaded in the "modules" tab. |
|
Regarding the |
|
Did you succeed in running testdriver ? PATH=../CUnit:$PATH ./testdriverd.exe And the end of the output: Run Summary: Type Total Ran Passed Failed Inactive Elapsed time = 0.012 seconds Let me know if you have differing results. |
|
Thanks for the hint -- no this has worked as well. I also succeeded in building the library and client/server examples for x64. Apart from a couple of warnings that we can clear up after merging this PR (PR #47 already has proper fixes for them), this looks good so far. |
|
I fixed the two warnings in libcoap. The more numerous 64 bits / 32 bits size mismatch warnings in coap-client are not platform specific, they are also harmless as far as I can tell. |
|
I submitted a 64-bit build of CUnit if you want to test with that. |
|
I am in favor of removing CUnit. |
…oject is no longer by default as part of the solution.
|
OK. I removed CUnit. |
…inydtls support # Conflicts: # Makefile.am # configure.ac # examples/client.c # examples/coap-rd.c # examples/coap-server.c # include/coap/address.h # include/coap/coap_io.h # include/coap/net.h # include/coap/prng.h # libcoap-1.map # libcoap-1.sym # src/net.c # src/platform/posix/coap_io.c
…LS support not enabled yet)
Add support for the windows (win32 with visual studio 2015) platform.
This PR incorporates as much of PR #47 as possible, after a lot of line by line cherry picking. It should be noted however that PR #47 builds on windows but is not functional, for example it does not cover receiving packets over UDP.
Changes in PR #47 related to TCP transport have been intentionally left aside.
The other notable deviation is that WITH_POSIX is no longer required and coap_config.h is not required to be included as a public header.
The included solution files build the static library, the examples and the regression test. To help building the regression test, a binary distribution of CUnit is included (in the win32 platform directory only).