Added RNG support for non-Linux/BSD systems #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please discard this pull request.. I've forgotten to change __rdtsc to time() or std::chrono, which will lead to issues using any other compiler than MSVC. I will change this and create a new pull request as soon as I arrived home. I will change it to either time() or std::chrono, I just need to know whether it's alright to use C++11 functions in this project. |
|
We need a cryptographically strong PRNG, and unfortunately, rand() and the like are not cryptographically secure. |
|
Alright, that's reasonable. At home I have a class which I've used before, it should meet your requirements. As soon as I arrived there, I will work on implementing it! :) |
|
@flurreh I just did it (and also the flags problem #5 ) ! Waiting for approval from @cryptopathe |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in issue #4, the CPRNG cannot seed automatically on non-Linux/BSD systems, as there's no /dev/random nor /dev/urandom.
I fixed this by using rand() in case of no random device being available.