New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Add error handling to env parsers #111

Merged

obalunenko merged 3 commits into master from develop

Jul 27, 2023

Owner

obalunenko commented Jul 26, 2023

No description provided.


          refactor: Add error handling to env parsers

8ad3e22

obalunenko self-assigned this

pull-request-size bot added the size/XL label

codecov bot commented Jul 26, 2023 •

edited

Loading

Codecov Report

Patch coverage: 77.27% and project coverage change: +2.55% 🎉

Comparison is base (1887d16) 84.00% compared to head (e39d55f) 86.55%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
+ Coverage   84.00%   86.55%   +2.55%     
==========================================
  Files           4        5       +1     
  Lines         425      409      -16     
==========================================
- Hits          357      354       -3     
+ Misses         68       54      -14     
- Partials        0        1       +1

Files Changed	Coverage Δ
internal/iface.go	`73.40% <0.00%> (+5.75%)`	⬆️
getenv.go	`95.45% <93.33%> (-4.55%)`	⬇️
internal/parsers.go	`97.83% <98.01%> (-1.14%)`	⬇️
internal/errors.go	`100.00% <100.00%> (ø)`

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

obalunenko force-pushed the develop branch from 82720d5 to 3cccfd8 Compare

July 27, 2023 00:11

pull-request-size bot added size/XXL and removed size/XL labels

obalunenko force-pushed the develop branch 3 times, most recently from dd42632 to de4cf8a Compare

July 27, 2023 00:36


          refactor: Get rid of internal default value parsers

479432b

obalunenko force-pushed the develop branch from de4cf8a to 479432b Compare

July 27, 2023 12:35


          style: Fix linter warnings

e39d55f

sonarqubecloud bot commented Jul 27, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

85.0% Coverage
0.0% Duplication

obalunenko merged commit 011a926 into master

obalunenko deleted the develop branch

July 27, 2023 12:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels