Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): updated controller-tools dep to 0.4.1 #3

Merged
merged 2 commits into from
Dec 11, 2020

Conversation

eudaimos
Copy link
Contributor

@eudaimos eudaimos commented Nov 24, 2020

Update the embedded dependency on controller-tools to v0.4.1 (latest at this time) to solve #2

Was able to validate locally to solve the problem with the following configuration in WORKSPACE

git_repository(
    name = "rules_kubebuilder",
    branch = "deps/controller-gen-to-0.4.1",
    remote = "https://github.com/eudaimos/rules_kubebuilder",
)

@ob
Copy link
Owner

ob commented Nov 25, 2020

Hey, thanks a lot for this PR. While this works, I wonder if it's worth decoupling the version of controller-gen from the version of rules_kubebuilder. For instance, we could add a version attribute to the rule and have both versions available. One concern with that approach would be bloating the download since the more releases they make the larger the tarball would be.

Or perhaps we could help with kubernetes-sigs/controller-tools#500 and download binaries on demand.

@eudaimos
Copy link
Contributor Author

What you're saying makes sense to me but that's getting out of my depth atm on this. Happy to assist but need a lot of assistance and I'm on a timeline on my end.

It's worth noting that I think I saw that kubebuilder's upcoming release is supposed to point to the updated version of controller-tools but I can't find where I saw that right now (prolly open in one of my 1000 open browser tabs)

@eudaimos
Copy link
Contributor Author

Also seems to me that providing that choice and flexibility would be great but not needed to hold up this PR

@ob ob merged commit 26f0059 into ob:main Dec 11, 2020
@eudaimos eudaimos deleted the deps/controller-gen-to-0.4.1 branch December 11, 2020 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants