Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V3.1 catchup #629

Merged
merged 11 commits into from
Jun 30, 2020
Merged

V3.1 catchup #629

merged 11 commits into from
Jun 30, 2020

Conversation

thomseddon
Copy link
Member

@thomseddon thomseddon commented Jun 11, 2020 •
edited
Loading

This is a rollup of all the changes in the 3.x branch, rebased against the current master.

Summary of the 3.x branch vs. the current 3.0.2 release: v3.0.2...3.x

This should bring in all the fixes pegged for 3.1, I've dropped the intermediate package.json / package-lock.json updates so to clean it up a little

Still todo in this branch:

@thomseddon thomseddon changed the title V3 catchup V3.1 catchup Jun 11, 2020
@thomseddon
Copy link
Member Author

I've removed #462 as introduces a potential race condition (#462 (comment)), discussion for how best to include request in the model context will continue in #254

@thomseddon thomseddon mentioned this pull request Jun 11, 2020
Closed
@thomseddon
Copy link
Member Author

Need to verify if #451 was correctly merged - validateScope will be called during the subsequent token request, need to check spec to see if it should also be validated when generating an auth code. Docs will need to be updated if it is invoked then and need to check if that will be backwards compatible

@thomseddon
Copy link
Member Author

As per https://tools.ietf.org/html/rfc6749#section-4.1.1 the scope is a required parameter for the authorisation request (which #451 fixes), and is not actually defined for the access token request (which is where the library currently tries to perform scope validation here)

I'm going to keep #451 in here for v3.1 and remove the scope validation from the auth code grant in v4

@thomseddon thomseddon mentioned this pull request Jun 27, 2020
Open
mjsalinger and others added 11 commits June 27, 2020 15:13
@mjsalinger @thomseddon
Updated .gitignore
09ecde6
@Pritilender @thomseddon
Changed 'hasOwnProperty' call in Request
99727f1
@Pritilender @thomseddon
Changed 'hasOwnProperty' call in Response
752705f
@nkzawa @thomseddon
set numArgs for promisify of generateAuthorizationCode
46bc95e
@maxtruxa @thomseddon
readme: Update Slack badge and link
eedb1b6
@razvanz @thomseddon
fix: issue correct expiry dates for tokens #444
7ec14b8 
related to a NodeJS (nodejs/node#7074) and furthermore
V8 bug (https://bugs.chromium.org/p/v8/issues/detail?id=3637); replaced
seconds calculation with milliseconds.
@mjsalinger @thomseddon
Merge pull request #451 from razvanz/fix/validate-scope-on-authorize
b3fe4d5 
 fix: validate requested scope on authorize request
@maxtruxa @thomseddon
Merge pull request #491 from mattgrande/master
4aa29b7 
docs: Ensure accessTokenExpiresAt is required
@mjsalinger @thomseddon
Merge pull request #471 from smartrecruiters/fix-migration-documentaiton
89eb13b 
docs: Correct tokens time scale for 2.x to 3.x  migration guide
@mjsalinger @thomseddon
Updated changelog
4abeb8b
@thomseddon
Tag 3.1.0-rc1
d9a23a4
@thomseddon
Copy link
Member Author

This is now released on npm as v3.1.0-rc1

I will cut the final 3.1 release next week assuming there are no issues.

This was referenced Jun 27, 2020
Open
Closed
@thomseddon thomseddon merged commit 0ba47c2 into master Jun 30, 2020
@thomseddon thomseddon deleted the v3-catchup branch June 30, 2020 20:46
@Uzlopak Uzlopak mentioned this pull request Nov 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@thomseddon @mjsalinger @Pritilender @nkzawa @maxtruxa @razvanz