Add x-oauth-basic nosec annotation & address gosec unhandled errors

[NickMeves]

Add a #nosec annotation to hardcoded x-oauth-basic password & handle finicky unhandled errors that weren't caught in a previous merge

Description

Gosec cleanup

Motivation and Context

Other PRs are getting intermittent Gosec issues.

How Has This Been Tested?

Unit Tests

Checklist:

• My change requires a change to the documentation or CHANGELOG.
• I have updated the documentation/CHANGELOG accordingly.
• I have created a feature (non-master) branch for my PR.

[NickMeves]

@gargath Do you mind taking a look at the logger.go changes? It looks like in the merge we ended up with a double \n in the standard logger (one to the buffer, one to the writer handler directly).

Gosec stopped me from just fixing up the annotation cause of the unhandled errors in logger (hence the little bit of scope creep). I'm disappointed its more fickle than we had hoped 😢

[wonderhoss]

Yeah, that makes sense. My bad for not spotting that. Everything in formatLogMessage() should go to the buffer, obviously.

[NickMeves]

Yeah, that makes sense. My bad for not spotting that. Everything in formatLogMessage() should go to the buffer, obviously.

No worries! I think the Gosec changes that touched the logger a bit heavily happened right before your logging change merged.

Thanks for giving this a peek 👍

[JoelSpeed]

@NickMeves I thought we had added gosec to the linter? Should this not have blocked the previous merge?

[NickMeves]

@JoelSpeed I'm more confused that people are getting blocked by Gosec findings that didn't pop up for me when I ran manually (I didn't get the hardcoded password issue for x-ouath-basic when running locally).

I'll keep an eye on this to make sure it isn't too much of a burden if it isn't consistent.