Remove nsswitch DNS resolution workaround #2371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuunit
force-pushed
the
feature/remove-go-dns-workaround
branch
from
ad2f62a to
5f8665d
Compare
tuunit
changed the title
kvanzuijlen
approved these changes
Dec 31, 2023
tuunit
added a commit
to tuunit/oauth2-proxy
that referenced
this pull request
Jan 21, 2024
* enhancement: Change base image from alpine to distroless (oauth2-proxy#2295) * Changed base image from alpine to distroless * chore: updated Makefile * fix: removed arm/v6 and ppc64le for distroless variant * Update Dockerfile * Update Makefile * docs: Add README-section, CHANGELOG-entry and --pull to prevent caching --------- Co-authored-by: Joel Speed <[email protected]> * Add possibility to encode the state param as UrlEncodedBase64 (oauth2-proxy#2312) * Add possibility to encode the state param as UrlEncodedBase64 * Update CHANGELOG.md * Update oauthproxy.go Co-authored-by: Jan Larwig <[email protected]> --------- Co-authored-by: Jan Larwig <[email protected]> * NGINX return 403 for sign_in (oauth2-proxy#2322) (oauth2-proxy#2323) Co-authored-by: Sven Ertel <[email protected]> * chore: Create sha256sum for tar instead of binary (oauth2-proxy#2343) * Create sha256sum for tar instead of binary * chore: Add checksum for binary * chore: Updated changelog --------- Co-authored-by: Joel Speed <[email protected]> * Log error details when failed loading CSRF cookie (oauth2-proxy#2345) * Log error details when failed loading CSRF cookie * Add a record about this PR to CHANGELOG.md --------- Co-authored-by: Ondrej Charvat <[email protected]> Co-authored-by: Joel Speed <[email protected]> * Feature - Add env variable support for alpha struct (oauth2-proxy#2375) * added envsubstring package and added simple test cases.imple tests. * added documentation * added changelog entry * added documentation to wrong file . * changed tests to ginkgo format * update project to use better maintained library * use defer to clear test variable after tests finished * updated docs for the new package documentation and fixed bad english * refactored function to "reduce" complexity. * updated changelog for new version updated readme * minor formatting --------- Co-authored-by: Haydn Evans <[email protected]> Co-authored-by: Joel Speed <[email protected]> * remove nsswitch workaround (oauth2-proxy#2371) Co-authored-by: Joel Speed <[email protected]> * feat: Added renovate configuration (oauth2-proxy#2377) * Feature/add option to skip loading claims from profile url (oauth2-proxy#2329) * add new flag skip-claims-from-profile-url * skip passing profile URL if SkipClaimsFromProfileURL * docs for --skip-claims-from-profile-url flag * update flag comment * update docs * update CHANGELOG.md * Update providers/provider_data.go Co-authored-by: Jan Larwig <[email protected]> * Add tests for SkipClaimsFromProfileURL * simplify tests for SkipClaimsFromProfileURL * generate alpha_config.md --------- Co-authored-by: Jan Larwig <[email protected]> * Add ability to configure username for Redis cluster connections (oauth2-proxy#2381) * Initial attempt. * Add CHANGELOG entry. * Drop commented-out Sentinel test. --------- Co-authored-by: Joel Speed <[email protected]> * chore(deps): update module golang.org/x/crypto to v0.17.0 [security] (oauth2-proxy#2400) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update github.com/ghodss/yaml digest to d8423dc (oauth2-proxy#2401) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Improved dev environment (oauth2-proxy#2211) * Improved dev env setup * Cleanup duplicate checks * Applied PR feedback * Updated go.mod/go.sum * go mod tidy * Update .devcontainer/devcontainer.json * Update pkg/http/server_test.go Co-authored-by: Jan Larwig <[email protected]> * Create launch.json * Update .devcontainer/Dockerfile * Apply suggestions from code review --------- Co-authored-by: Jan Larwig <[email protected]> * feature: add release automation workflows (oauth2-proxy#2224) * feature: add release automation workflows * deactivate provenancee because of behaviour change with buildx v0.10.0 * add changelog section extraction for github release notes * fix registry path; fix EOF * use correct version of golangci-lint; add additional workflow step for fetching all dependencies * chore(deps): update module github.com/bsm/redislock to v0.9.4 (oauth2-proxy#2406) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * initial commit for docusaurus 3 upgrade * fix mdx errors * fix mdx issues * fix routing issues * update docs generation workflow * fix version * fix permissions * move slack to header * remove background color and minify * Update docs/docs/configuration/providers/openid_connect.md Co-authored-by: Koen van Zuijlen <[email protected]> * Update docs/docs/configuration/providers/openid_connect.md Co-authored-by: Koen van Zuijlen <[email protected]> * Update docs/docs/configuration/providers/openid_connect.md Co-authored-by: Koen van Zuijlen <[email protected]> * Update docs/docs/configuration/providers/gitlab.md Co-authored-by: Koen van Zuijlen <[email protected]> * Update docs/docs/configuration/providers/gitlab.md Co-authored-by: Koen van Zuijlen <[email protected]> * Update docs/docs/configuration/providers/github.md Co-authored-by: Koen van Zuijlen <[email protected]> * Update docs/docs/configuration/providers/github.md Co-authored-by: Koen van Zuijlen <[email protected]> * Update docs/docs/configuration/providers/github.md Co-authored-by: Koen van Zuijlen <[email protected]> * Update docs/docs/configuration/providers/github.md Co-authored-by: Koen van Zuijlen <[email protected]> --------- Co-authored-by: Koen van Zuijlen <[email protected]> Co-authored-by: Joel Speed <[email protected]> Co-authored-by: Jan Brezina <[email protected]> Co-authored-by: WhiteRabbit-Code <[email protected]> Co-authored-by: Sven Ertel <[email protected]> Co-authored-by: charvadzo <[email protected]> Co-authored-by: Ondrej Charvat <[email protected]> Co-authored-by: Haydn Evans <[email protected]> Co-authored-by: Nils Gustav Stråbø <[email protected]> Co-authored-by: Ross Golder <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As described in #2370 the nsswitch workaround introduced in #400 to properly handle DNS resolution has not been necessary since Go1.16: golang/go@c800222
Therefore, removing the file introduced for the workaround.
Motivation
Cleanup
How Has This Been Tested?
Locally build and test run a docker image with extra_hosts.
Checklist: