fix: move oidc scope logic to oidc provider #1989
Conversation
tuunit
changed the title
tuunit
changed the title
|
@Kyserbyte I tested your issue with the scope missing for the KeycloakOIDC provider and couldn't produce it. As the KeycloakOIDC provider is a extension of the OIDC provider it should have the same default scope of "openid email profile". Nevertheless, I think it is a good idea to move this logic from the generic provider.go to the OIDC provider. |
providers/providers.go
Outdated
| } | ||
| } | ||
| if providerConfig.OIDCConfig.UserIDClaim == "" { | ||
| providerConfig.OIDCConfig.UserIDClaim = "email" |
There was a problem hiding this comment.
As this struct instance is not a reference and not used after this line it was essentially just dead code.
tuunit
force-pushed
the
feature/add-default-scope-to-keycloak-oidc
branch
from
8d90b60 to
a907c7d
Compare
tuunit
changed the title
|
This pull request has been inactive for 60 days. If the pull request is still relevant please comment to re-activate the pull request. If no action is taken within 7 days, the pull request will be marked closed. |
|
This pull request has been inactive for 60 days. If the pull request is still relevant please comment to re-activate the pull request. If no action is taken within 7 days, the pull request will be marked closed. |
|
@JoelSpeed please reopen :) |
|
The branch has since been force pushed, so I can't currently reopen right now |
Description and Motivation
The OIDC provider shouldn't be treated as anything specially where as all the other providers have there internal scope logic defined in the specific provider files the scope logic for oidc and in extension the keycloak-oidc provider is located in the providers.go.
To align the OIDC and Keycloak OIDC provider I moved the logic to the oidc.go provider file.
How Has This Been Tested?
Checklist: