Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Go 1.11 from Travis CI #168

Merged
merged 3 commits into from
Jun 3, 2019
Merged

Drop Go 1.11 from Travis CI #168

merged 3 commits into from
Jun 3, 2019

Conversation

JoelSpeed
Copy link
Member

Description

Drop testing of OAuth2 Proxy against Go 1.11

Motivation and Context

Go 1.11 is slow and constantly times out for our CI. We test against 1.12, I see little point testing against multiple versions.

Checklist:

  • My change requires a change to the documentation or CHANGELOG.
  • I have updated the documentation/CHANGELOG accordingly.
  • I have created a feature (non-master) branch for my PR.

@JoelSpeed JoelSpeed requested review from a team and loshz May 30, 2019 13:58
@JoelSpeed JoelSpeed changed the title Drop 1.11 Drop Go 1.11 from Travis CI May 30, 2019
@loshz
Copy link
Member

loshz commented May 30, 2019

LGTM - we can also bump the Go version in the configure script on lines 84 and 94.

@JoelSpeed
Copy link
Member Author

@syscll Have bumped the configure script as requested

loshz
loshz approved these changes Jun 3, 2019
View reviewed changes
Copy link
Member

@loshz loshz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JoelSpeed JoelSpeed merged commit 40cf6b2 into master Jun 3, 2019
@JoelSpeed JoelSpeed deleted the drop-1.11 branch June 3, 2019 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loshz loshz loshz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoelSpeed @loshz