Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate GAP-Signature and add a warning on usage #1103

Merged
merged 1 commit into from
Mar 14, 2021
Merged

Deprecate GAP-Signature and add a warning on usage #1103

merged 1 commit into from
Mar 14, 2021

Conversation

NickMeves
Copy link
Member

#648

Checklist:

  • My change requires a change to the documentation or CHANGELOG.
  • I have updated the documentation/CHANGELOG accordingly.
  • I have created a feature (non-master) branch for my PR.

@NickMeves NickMeves requested a review from a team as a code owner March 13, 2021 02:50
@NickMeves NickMeves force-pushed the gap-signature-deprecation-warning branch 2 times, most recently from 6eebf8f to 495bd27 Compare March 13, 2021 02:55
JoelSpeed
JoelSpeed reviewed Mar 13, 2021
View reviewed changes
Copy link
Member

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No real issue with this, just wonder if it's worth extending the warning message to say we plan to remove in a future release?

pkg/validation/options.go Outdated Show resolved Hide resolved
@NickMeves NickMeves force-pushed the gap-signature-deprecation-warning branch from 35c3a0a to 9b4daaf Compare March 14, 2021 16:39
NickMeves
NickMeves commented Mar 14, 2021
View reviewed changes
pkg/validation/options.go
msgs = configureLogger(o.Logging, msgs)
msgs = parseSignatureKey(o, msgs)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just making configureLogger first so it is available to everything?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should yeah 🤔

JoelSpeed
JoelSpeed approved these changes Mar 14, 2021
View reviewed changes
Copy link
Member

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can follow up to reconfigure logging to the top as and when we need to

@NickMeves NickMeves merged commit 4d9de06 into master Mar 14, 2021
@NickMeves NickMeves deleted the gap-signature-deprecation-warning branch March 14, 2021 16:47
k-jell pushed a commit to liquidinvestigations/oauth2-proxy that referenced this pull request Apr 6, 2022
@k-jell
Deprecate GAP-Signature and add a warning on usage (oauth2-proxy#1103)
59bf378
Jing-ze pushed a commit to Jing-ze/oauth2-proxy that referenced this pull request Nov 19, 2024
@hanxiantao
feat: support ext_auth wasmplugin (oauth2-proxy#1103)
c0f2caf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed JoelSpeed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NickMeves @JoelSpeed