example usage of media callbacks #138
Conversation
examples/play_buffer.py
Outdated
| #!/usr/bin/env python3 | ||
|
|
||
| import argparse | ||
| import ctypes as ct |
There was a problem hiding this comment.
This saves 4 bytes, but hampers readability. I think it would be nice to keep a plain import ctypes
| import os | ||
|
|
||
| import vlc | ||
|
|
There was a problem hiding this comment.
It would help to have some docstring here, explaining the overall goal of the example and describing in simple sentences how it works, and the APIs it uses.
|
It is good to have some examples, especially in the callbacks area which is always a bit complex. The example looks fine to me, not overly complex but at the same time using a non trivial API. |
|
Let me know if you feel it is enough or you would add something more specific ;) I didn't add the copyright/license information, I don't know how you would like to manage it. |
examples/play_buffer.py
Outdated
| @@ -50,7 +75,7 @@ def get_data(self): | |||
| """ | |||
| It reads the current file in the list and returns the binary data | |||
| In this example it reads from file, but it could have downloaded data from an url | |||
| """ | |||
| i""" | |||
| @@ -1,7 +1,32 @@ | |||
| #!/usr/bin/env python3 | |||
|
|
|||
| # Author: A.Invernizzi (@albestro on GitHub) | |||
There was a problem hiding this comment.
For the license, there are currently 2 different types of licenses for examples (GPLv2+ or MIT), but the best option for examples may indeed be the more permissive MIT license (as in cocoavlc), so you can use cocoavlc as reference if it is OK for you.
examples/play_buffer.py
Outdated
| @@ -3,6 +3,28 @@ | |||
| # Author: A.Invernizzi (@albestro on GitHub) | |||
| # Date: Jun 03, 2020 | |||
|
|
|||
| # MIT License <http://OpenSource.org/licenses/MIT> | |||
| # | |||
| # Copyright (C) 2017-2018 -- mrJean1 at Gmail dot com | |||
There was a problem hiding this comment.
One last thing: could you change the copyright line to
# Copyright (c) 2020 -- A. Invernizzi, @albestro on github
or
# Copyright (c) 2020 -- the VideoLAN team
for a copyright assignment to the videolan project.
There was a problem hiding this comment.
I'm sorry...completely missed it, just copy&paste. My fault.
|
Thanks a lot for the contribution and the handling of feedback |
Close #88
I wrote a basic script trying to show how to use callbacks. I know it's not the most basic example, but I thought it would have been useful for the final user for better understanding the mechanism.
Looking forward for your feedback on how to refine/improve it.