Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to link with MSVC static runtime (OFF by default) #16

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

sgallou
Copy link
Contributor

@sgallou sgallou commented Sep 26, 2022

Like for oatpp, oatpp-swagger and oatpp-websocket, add option to link with MSVC static runtime (OFF by default)

Remove quotes on CMake add_subdirectory calls
@sgallou
Copy link
Contributor Author

sgallou commented Sep 27, 2022

I don't understand why some checks failed (not all). OpenSSL seem's to be missing. @lganzzzo , can you check why, please ?

@sgallou
Copy link
Contributor Author

sgallou commented Sep 28, 2022

Seems that MacOS build failed because of OpenSSL dependency not found by CMake. I think that problem is related to the build job, not to my changes.

Detailed error message is "Could NOT find OpenSSL, try to set the path to OpenSSL root folder in the system variable OPENSSL_ROOT_DIR (missing: OPENSSL_CRYPTO_LIBRARY OPENSSL_INCLUDE_DIR) (Required is at least version "1.1")

@lganzzzo Can you check that ?

@lganzzzo
Copy link
Member

@sgallou ,
Yes, it looks like the issue of vcpkg which is used in Mac pipeline.
If it continue to occur - I'll remove vcpkg from the Mac pipeline.
Rerunning...

@sgallou
Copy link
Contributor Author

sgallou commented Sep 28, 2022

@lganzzzo Same problem again :-(

@lganzzzo lganzzzo merged commit c689acb into oatpp:master Sep 29, 2022
@lganzzzo
Copy link
Member

Merged.
Thanks for the PR!
I'll update the pipeline...

@sgallou sgallou deleted the linkWithMsvcStaticRuntimeOption branch September 30, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants