-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
古い署名を削除 & Streamで同期しない #32
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rect to publish sigs
ironbeer
reviewed
Jul 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tak1827 途中ですが一旦submitします
ironbeer
reviewed
Jul 16, 2024
ironbeer
reviewed
Jul 16, 2024
ironbeer
reviewed
Jul 17, 2024
ironbeer
approved these changes
Jul 18, 2024
tak1827
added a commit
that referenced
this pull request
Jul 18, 2024
* tmp improve several starting code * bunches of improves * reduced bunches of goroutine to improve performance and reduce potentially bug * respond review by ironbeer * reduce concurency in p2p node start * respond review by ironbeer * fix verifier testcase * fix VerseDiscovery testcase * version up golang-ipc to fix close bug * force to stop ipc server * improve stop logging * fix verse discovery unstopable bug * improve logging * fix verifier loop bug * introduce formatting of proto * submitter: clean sig * p2p: no open stream when received published sig * during startup, no start submitter, just start when new verse discroverd * verse: get nextIndex with confirmation * verifier: clearn up old sigs * update config * fix config test error * correctly handle http close error on msvr and psvr * verse discovery: immediate discorver at first tick, improve loging, validate setting * verse discovery: add inital endpoint reachable check * fix disk optimiser ticker mis config * verse discovery: synchronously try the first discovery * logging verifer/submitter added verse * handle already verified index * fix config test by optinally validating application level validation * log when already index is verified * replace ioutil to io * disable block / event collector * verifier: directly feth events, no from database as the collecters are abolished * p2p: stop latest sig publish loop * submitter: include chainid to log * verifier: fix publishing issue, missing contract, p2p node is the correct to publish sigs * update start to follow up verifier submitter update * accept published old sigs to receive * submitter: improve log * config: add start block offset * verifier: fix timeout error at the first log fetch * verifier: filter log by contract address * verifier: fix missing by contract address filtering when fetch log * increment version * verifier: log improve * apply feedback fro ironbeer * respond feedback from ironbeer #32 * delete unused code and mark deplicated * node: delete publishLoop and meterLoop * fix feadback from ironbeer #32 * verifier: order by batch_index when publish unverifierd logs * improve log * verifier: fix skip iter block * verifier: retry failed log 1h later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes