Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

古い署名を削除 & Streamで同期しない #32

Merged
merged 42 commits into from
Jul 18, 2024

Conversation

tak1827
Copy link
Contributor

@tak1827 tak1827 commented Jun 26, 2024

Changes

  • Verifier/Submitterで古い署名を削除する機能をいれた
  • Validator
    • 都度コントラクトのEventをFetch。nextIndex以上の署名をPublishする形に変更。
    • PubSubのSubscribeを停止。受け取っても仕方ないから。
      • 署名を受け取ってP2Pで同期するのをやめた。自分の署名しかPublishしない(上の処理)
    • Block/Event Collectorを廃止
  • Submitter
    • P2P NodeがPublishされた署名を受けとったときに、Streamを開いて同期するのを止めた。ただ、受け取った署名を保存するだけ
  • protoをformat

@tak1827 tak1827 requested a review from ironbeer June 26, 2024 03:02
@tak1827 tak1827 changed the base branch from main to feat/reduce-goroutine June 26, 2024 03:03
Copy link
Collaborator

@ironbeer ironbeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tak1827 途中ですが一旦submitします

config/config.go Outdated Show resolved Hide resolved
cmd/start.go Show resolved Hide resolved
cmd/start.go Outdated Show resolved Hide resolved
config/verse_discovery.go Outdated Show resolved Hide resolved
cmd/start.go Outdated Show resolved Hide resolved
database/op_signature.go Outdated Show resolved Hide resolved
database/op_signature.go Outdated Show resolved Hide resolved
@tak1827 tak1827 requested a review from ironbeer July 16, 2024 12:42
submitter/submitter.go Outdated Show resolved Hide resolved
verifier/verifier.go Outdated Show resolved Hide resolved
verifier/verifier.go Outdated Show resolved Hide resolved
verifier/verifier.go Outdated Show resolved Hide resolved
@tak1827 tak1827 requested a review from ironbeer July 17, 2024 06:50
cmd/start.go Show resolved Hide resolved
submitter/submitter.go Outdated Show resolved Hide resolved
ethutil/client.go Outdated Show resolved Hide resolved
verifier/verifier.go Show resolved Hide resolved
verifier/verifier.go Show resolved Hide resolved
@tak1827 tak1827 requested a review from ironbeer July 17, 2024 14:16
@tak1827 tak1827 merged commit 378c360 into feat/reduce-goroutine Jul 18, 2024
1 check passed
tak1827 added a commit that referenced this pull request Jul 18, 2024
* tmp improve several starting code

* bunches of improves

* reduced bunches of goroutine to improve performance and reduce potentially bug

* respond review by ironbeer

* reduce concurency in p2p node start

* respond review by ironbeer

* fix verifier testcase

* fix VerseDiscovery testcase

* version up golang-ipc to fix close bug

* force to stop ipc server

* improve stop logging

* fix verse discovery unstopable bug

* improve logging

* fix verifier loop bug

* introduce formatting of proto

* submitter: clean sig

* p2p: no open stream when received published sig

* during startup, no start submitter, just start when new verse discroverd

* verse: get nextIndex with confirmation

* verifier: clearn up old sigs

* update config

* fix config test error

* correctly handle http close error on msvr and psvr

* verse discovery: immediate discorver at first tick, improve loging, validate setting

* verse discovery: add inital endpoint reachable check

* fix disk optimiser ticker mis config

* verse discovery: synchronously try the first discovery

* logging verifer/submitter added verse

* handle already verified index

* fix config test by optinally validating application level validation

* log when already index is verified

* replace ioutil to io

* disable block / event collector

* verifier: directly feth events, no from database as the collecters are abolished

* p2p: stop latest sig publish loop

* submitter: include chainid to log

* verifier: fix publishing issue, missing contract, p2p node is the correct to publish sigs

* update start to follow up verifier submitter update

* accept published old sigs to receive

* submitter: improve log

* config: add start block offset

* verifier: fix timeout error at the first log fetch

* verifier: filter log by contract address

* verifier: fix missing by contract address filtering when fetch log

* increment version

* verifier: log improve

* apply feedback fro ironbeer

* respond feedback from ironbeer #32

* delete unused code and mark deplicated

* node: delete publishLoop and meterLoop

* fix feadback from ironbeer #32

* verifier: order by batch_index when publish unverifierd logs

* improve log

* verifier: fix skip iter block

* verifier: retry failed log 1h later
@tak1827 tak1827 deleted the feat/no-stream-and-clean-sig branch July 18, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants