-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prototype manifest v3 extension #2084
base: master
Are you sure you want to change the base?
Changes from 9 commits
36a543e
1a0a61f
736928b
b826ddb
69263fc
9685f6a
e5dc53c
e81a4b0
6d03d50
ffa9ad8
17061b0
1fb1a15
3d5876b
7bfe2e2
6fcd145
73e0e10
7671cb9
a8f474e
4a61f46
3a6223d
c88b2fc
f180d51
dffce4d
874365b
55d8b8b
64f8789
aaccd7a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,6 +12,7 @@ export function FromLedgerWebExtension() { | |
webExtensionUSBLedgerAccess={() => { | ||
navigate('/open-wallet/ledger/usb') | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. uh I thought our mechanism to request ledger permissions in ext worked completely differently. It requires redux syncing from openLedgerAccessPopup? :O |
||
openLedgerAccessPopup(href) | ||
// check if ledger popup works | ||
}} | ||
/> | ||
) | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3194,10 +3194,10 @@ | |
resolved "https://registry.yarnpkg.com/@types/web-bluetooth/-/web-bluetooth-0.0.20.tgz#f066abfcd1cbe66267cdbbf0de010d8a41b41597" | ||
integrity sha512-g9gZnnXVq7gM7v3tJCWV/qw7w+KeOlSHAhgF9RytFyifW6AF61hdT2ucrYhPq9hLs5JIryeupHV3qGk95dH9ow== | ||
|
||
"@types/webextension-polyfill@0.10.7": | ||
version "0.10.7" | ||
resolved "https://registry.yarnpkg.com/@types/webextension-polyfill/-/webextension-polyfill-0.10.7.tgz#de059250599733a60ed26c8a0c81e21e11183b90" | ||
integrity sha512-10ql7A0qzBmFB+F+qAke/nP1PIonS0TXZAOMVOxEUsm+lGSW6uwVcISFNa0I4Oyj0884TZVWGGMIWeXOVSNFHw== | ||
"@types/webextension-polyfill@0.12.1": | ||
version "0.12.1" | ||
resolved "https://registry.yarnpkg.com/@types/webextension-polyfill/-/webextension-polyfill-0.12.1.tgz#8dae244fe094cbb541005362e8e22f16671f6054" | ||
integrity sha512-xPTFWwQ8BxPevPF2IKsf4hpZNss4LxaOLZXypQH4E63BDLmcwX/RMGdI4tB4VO4Nb6xDBH3F/p4gz4wvof1o9w== | ||
|
||
"@types/yargs-parser@*": | ||
version "20.2.0" | ||
|
@@ -9954,10 +9954,10 @@ [email protected]: | |
lodash.assignin "^4.2.0" | ||
lodash.clonedeep "^4.5.0" | ||
|
||
webextension-polyfill@0.10.0: | ||
version "0.10.0" | ||
resolved "https://registry.yarnpkg.com/webextension-polyfill/-/webextension-polyfill-0.10.0.tgz#ccb28101c910ba8cf955f7e6a263e662d744dbb8" | ||
integrity sha512-c5s35LgVa5tFaHhrZDnr3FpQpjj1BB+RXhLTYUxGqBVN460HkbM8TBtEqdXWbpTKfzwCcjAZVF7zXCYSKtcp9g== | ||
webextension-polyfill@0.12.0: | ||
version "0.12.0" | ||
resolved "https://registry.yarnpkg.com/webextension-polyfill/-/webextension-polyfill-0.12.0.tgz#f62c57d2cd42524e9fbdcee494c034cae34a3d69" | ||
integrity sha512-97TBmpoWJEE+3nFBQ4VocyCdLKfw54rFaJ6EVQYLBCXqCIpLSZkwGgASpv4oPt9gdKCJ80RJlcmNzNn008Ag6Q== | ||
|
||
webidl-conversions@^7.0.0: | ||
version "7.0.0" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
webext-redux v4 supports manifest v3 and service workers, but looking at PR we will remove this dep completely. Did you encounter any issues when using it? Or did you find that brainstorming the problem without it was simply easier?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to make it simpler and more like our web wallet
webext-redux is needed to sync multiple extension popups and/or communication with dapps. We still don't have dapp communication, and we probably don't need multiple popups.
(we could also sync multiple popups the same way we sync web wallet tabs by enabling
wallet/src/app/state/persist/index.ts
Lines 19 to 20 in 8871626