Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Roboto Mono font for amounts #2006

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Use Roboto Mono font for amounts #2006

merged 2 commits into from
Jul 16, 2024

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Jul 15, 2024

Before After
wallet dev oasis io_account_oasis1qrtyn2q78jv6plrmexrsrv4dh89wv4n49udtg2km localhost_3000_account_oasis1qrtyn2q78jv6plrmexrsrv4dh89wv4n49udtg2km

@lukaw3d lukaw3d requested a review from buberdds July 15, 2024 16:55
Copy link

github-actions bot commented Jul 15, 2024

Deployed to Cloudflare Pages

Latest commit: f4955f1969ab0fddd4d5748c2e0d6c004882d097
Status:✅ Deploy successful!
Preview URL: https://619d9a77.oasis-wallet.pages.dev

@buberdds
Copy link
Contributor

is the "after" screenshot up to date? in a preview URL spacing looks weird
Screenshot from 2024-07-15 19-04-40

Comment on lines 23 to 33
/** Use Arial for "." and "," instead of Roboto Mono. */
@font-face {
font-family: 'Roboto Mono';
font-style: normal;
font-weight: 300;
font-display: swap;
src: local("Arial");
unicode-range: U+002E, U+002C;
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@buberdds is the "after" screenshot up to date? in a preview URL spacing looks weird

It is up to date. I tried it in Firefox now, and it looks like your screenshot. So this code isn't working consistently 🤷

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to use Rubik and it fixes my Firefox
localhost_3000_account_oasis1qrtyn2q78jv6plrmexrsrv4dh89wv4n49udtg2km

Try again?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks much better

@lukaw3d lukaw3d enabled auto-merge July 16, 2024 15:32
@lukaw3d lukaw3d merged commit fbd656d into master Jul 16, 2024
12 of 13 checks passed
@lukaw3d lukaw3d deleted the lw/mono-amounts branch July 16, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants