Change transaction layout to accommodate large numbers in extension #2003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lukaw3d
commented
Jul 13, 2024
lukaw3d
commented
| Before | After |
|---|---|
 |
 |
 |
 |
 |
 |
Deployed to Cloudflare Pages
|
buberdds
approved these changes
Jul 15, 2024
| @@ -428,7 +429,7 @@ export function Transaction(props: TransactionProps) { | |||
| </Text> | |||
| </CardHeader> | |||
| <StyledCardBody margin={{ bottom: 'small' }}> | |||
| <Box width="75%"> | |||
| <Box> | |||
There was a problem hiding this comment.
just a personal preference, prev version looks a bit better on desktop (when tx details adopt to screen width)
we could add style={{ flex: 1 }} here and make attr in L~447 width="max-content" conditional.
Did not test it fully and personally don't care that much about it.
There was a problem hiding this comment.
I didn't find a good way to prevent wobbly layout yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.