Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move mobile footer to profile dropdown #1961

Merged
merged 9 commits into from
Jul 6, 2024
Merged

Move mobile footer to profile dropdown #1961

merged 9 commits into from
Jul 6, 2024

Conversation

buberdds
Copy link
Contributor

@buberdds buberdds commented May 29, 2024 •
edited
Loading

Closes #1952

@github-actions GitHub Actions
Copy link

github-actions bot commented May 29, 2024 •
edited
Loading

Deployed to Cloudflare Pages

Latest commit: 2db50770da58f9b34ade9aca25b037b47fe71210
Status:✅ Deploy successful!
Preview URL: https://9ebc7efc.oasis-wallet.pages.dev

@buberdds buberdds force-pushed the mz/footer branch 5 times, most recently from 965da1d to 6177bbc Compare May 30, 2024 08:30
@buberdds buberdds marked this pull request as ready for review May 30, 2024 08:34
@buberdds buberdds force-pushed the mz/footer branch 6 times, most recently from c6f092b to eadafcf Compare May 30, 2024 11:03
@codecov Codecov
Copy link

codecov bot commented May 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.61%. Comparing base (b8ef6ea) to head (c6f092b).
Report is 17 commits behind head on master.

❗ Current head c6f092b differs from pull request most recent head d0df54a

Please upload reports for the commit d0df54a to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1961      +/-   ##
==========================================
- Coverage   79.62%   76.61%   -3.02%     
==========================================
  Files         210      203       -7     
  Lines        5409     5264     -145     
  Branches     1001      971      -30     
==========================================
- Hits         4307     4033     -274     
- Misses       1102     1231     +129
Flag Coverage Δ
cypress ?
jest 76.61% <100.00%> (+0.91%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/app/components/Footer/PageFooter.tsx 100.00% <100.00%> (ø)
src/app/components/Footer/index.tsx 93.02% <ø> (-0.16%) ⬇️
...rc/app/components/MobileFooterNavigation/index.tsx 97.36% <100.00%> (-0.14%) ⬇️
...app/components/Toolbar/Features/Settings/index.tsx 100.00% <100.00%> (+20.00%) ⬆️
src/app/index.tsx 100.00% <100.00%> (ø)

... and 70 files with indirect coverage changes

@buberdds buberdds requested review from lukaw3d and lubej May 30, 2024 11:14
@lubej
Copy link
Collaborator

lubej commented May 30, 2024

Wasn't footer supposed to be only visible in settings on both mobile & desktop?

@buberdds
Copy link
Contributor Author

buberdds commented May 30, 2024 •
edited
Loading

Discussed during UX meeting. We will probably have another "light version" of footer for desktop and mobile. Requirements will be updated next week.

@buberdds
Copy link
Contributor Author

buberdds commented Jun 28, 2024 •
edited
Loading

new designs
https://www.figma.com/design/O4ns1tPoFe0MwPjfuigZGH/Wallet-%2F-Address-Book?node-id=332-1258&t=PgFolLK0QWKSiONT-0

https://www.figma.com/design/XDufbkj5hMKbdQEmaTsDqc/Wallet-Copy-%26-UI--Tweaks?node-id=88-23&t=YylIdPbzklaDslm3-0

  • the messaging on desktop and mobile views is different (invert the order of terms and conditions)
  • dekstop is always visible but it has a new layout
  • tablet (medium) = mobile (small)
  • revert GitHub issue Update footer text #1910 and PR (show/hide)
  • current footer moved to settings for opened mobile
  • keep current footer for mobile not opened account
  • move footer to the bottom of a page

@buberdds buberdds force-pushed the mz/footer branch 4 times, most recently from 672d251 to 16a132a Compare July 1, 2024 11:04
@buberdds
Copy link
Contributor Author

buberdds commented Jul 1, 2024 •
edited
Loading

approved by Don, but need to stick footer to the bottom of the page (mobile - remove margin when rendering in settings, desktop - push footer to bottom when content is small)

@buberdds buberdds force-pushed the mz/footer branch 2 times, most recently from fea117a to d0df54a Compare July 2, 2024 08:58
@buberdds
Copy link
Contributor Author

buberdds commented Jul 2, 2024

ready for review

@buberdds buberdds merged commit 857db8a into master Jul 6, 2024
13 checks passed
@buberdds buberdds deleted the mz/footer branch July 6, 2024 07:53
lukaw3d added a commit that referenced this pull request Jul 30, 2024
@lukaw3d
Fix footer to work with existing translations
6e29863 
Example of existing translation that was broken:
`"version": "Različica <ReleaseLink/> (<CommitLink/>) zgrajena {{buildTime}}"`

Reverts part of #1941 and #1961.
@lukaw3d lukaw3d mentioned this pull request Jul 30, 2024
Merged
lukaw3d added a commit that referenced this pull request Jul 30, 2024
@lukaw3d
Fix footer to work with existing translations
2c5dddf 
Example of existing translation that was broken:
`"version": "Različica <ReleaseLink/> (<CommitLink/>) zgrajena {{buildTime}}"`

Reverts part of #1941 and #1961.
lukaw3d added a commit that referenced this pull request Jul 31, 2024
@lukaw3d
Fix footer to work with existing translations
af9570a 
Example of existing translation that was broken:
`"version": "Različica <ReleaseLink/> (<CommitLink/>) zgrajena {{buildTime}}"`

Reverts part of #1941 and #1961.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaw3d lukaw3d lukaw3d approved these changes

@lubej lubej Awaiting requested review from lubej

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move mobile footer to Profile Settings
3 participants
@buberdds @lubej @lukaw3d