Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transaction preview layout in extension and loading text size #1937

Merged
merged 3 commits into from
May 15, 2024

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented May 15, 2024

Before After
localhost_3000_account_oasis1qrtyn2q78jv6plrmexrsrv4dh89wv4n49udtg2km_active-delegations(extension375x600 + scrollbar) (1) localhost_3000_account_oasis1qrtyn2q78jv6plrmexrsrv4dh89wv4n49udtg2km_active-delegations(extension375x600 + scrollbar)
localhost_3000_account_oasis1qrtyn2q78jv6plrmexrsrv4dh89wv4n49udtg2km_active-delegations(extension375x600 + scrollbar) (3) localhost_3000_account_oasis1qrtyn2q78jv6plrmexrsrv4dh89wv4n49udtg2km_active-delegations(extension375x600 + scrollbar) (2)

@lukaw3d lukaw3d requested review from buberdds and lubej May 15, 2024 01:03
Copy link

github-actions bot commented May 15, 2024

Deployed to Cloudflare Pages

Latest commit: 31a780b13df5c6f2c843219710864b28c33a60e4
Status:✅ Deploy successful!
Preview URL: https://f17cfc0c.oasis-wallet.pages.dev

@@ -108,9 +108,9 @@ export function AccountPage(props: AccountPageProps) {
{active && <TransactionModal />}
{(stake.loading || account.loading) && (
<Layer modal background="background-front" responsive={false}>
<Box pad="medium" gap="medium" direction="row" align="center">
<Box pad="medium" gap="medium" direction="row" align="center" width={'max-content'}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

width="max-content"

@lukaw3d lukaw3d force-pushed the lw/tx-building-text-size branch from b24d65c to f4a3e4f Compare May 15, 2024 22:53
@lukaw3d lukaw3d force-pushed the lw/tx-building-text-size branch from f4a3e4f to 31a780b Compare May 15, 2024 22:54
@lukaw3d lukaw3d merged commit dd2ba1f into master May 15, 2024
13 checks passed
@lukaw3d lukaw3d deleted the lw/tx-building-text-size branch May 15, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants