Add validation message to required checkbox in ChoosePasswordFields #1936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
lukaw3d
force-pushed
the
lw/checkbox-focus
branch
from
7619195 to
3ffdb93
Compare
buberdds
approved these changes
May 15, 2024
| @@ -69,7 +72,6 @@ export function ChoosePasswordFields() { | |||
| > | |||
| <CheckBox | |||
| name="profileStorageUndependableAcknowledge" | |||
| required | |||
There was a problem hiding this comment.
I would remove this prop in ChoosePasswordInputFields password1 field too so validation is consistent.
There was a problem hiding this comment.
as long as it works everywhere. looks like it's used in more than one place.
lukaw3d
force-pushed
the
lw/checkbox-focus
branch
from
f97229a to
2f76359
Compare
lukaw3d
force-pushed
the
lw/checkbox-focus
branch
from
2f76359 to
0aa3731
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1925
(also improved checkbox focus state in case we don't have validation messages in some component)