Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assemble changes for 1.10.0 release #1889

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Assemble changes for 1.10.0 release #1889

merged 1 commit into from
Apr 11, 2024

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Apr 11, 2024

No description provided.

@lukaw3d lukaw3d requested review from buberdds, tjanez and lubej April 11, 2024 19:38
Copy link

github-actions bot commented Apr 11, 2024

Deployed to Cloudflare Pages

Latest commit: 1ed2496453886efb29a36c165296f9b0e2a1a1b2
Status:✅ Deploy successful!
Preview URL: https://fd8351a4.oasis-wallet.pages.dev

CHANGELOG.md Outdated
- E2E test recovering from fatal errors in extension
([#1865](https://github.com/oasisprotocol/oasis-wallet-web/issues/1865))

- Show better description in Delete Profile dialog if user forgot their password
Copy link
Contributor

@buberdds buberdds Apr 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

belongs more to Improvements section

This comment was marked as off-topic.

Copy link

socket-security bot commented Apr 11, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Install scripts npm/[email protected]
  • Install script: postinstall
  • Source: node scripts/postinstall
Install scripts npm/@swc/[email protected]
  • Install script: postinstall
  • Source: node postinstall.js
Install scripts npm/[email protected]
  • Install script: postinstall
  • Source: node index.js --exec install

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@lukaw3d lukaw3d merged commit a68220e into master Apr 11, 2024
11 of 13 checks passed
@lukaw3d lukaw3d deleted the lw/release branch April 11, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants